Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excit Integration: Iterators and Tiling Iterators #58

Open
iskra-anl opened this issue Apr 20, 2021 · 7 comments
Open

Excit Integration: Iterators and Tiling Iterators #58

iskra-anl opened this issue Apr 20, 2021 · 7 comments

Comments

@iskra-anl
Copy link
Contributor

In GitLab by @perarnau on Apr 7, 2020, 13:34

  • embed excit inside aml (git submodule)
  • design a new tiling iterator interface based on it
  • validate on old benchmarks (MCHPC19)

Related to #21.
Might be blocked by #51

Integrating Excit

Choice between submodule and external dependency: submodule is easier for development.

Tiling Iterator API

First design choice: tiling iterator object or just a way to retrieve a retrieve a tile using an iterator state as input ?

object tiling method
pros "hide" excit from the user simple implementation
cons pretty much need an entire building block with generic API and implementation excit becomes part of AML API

One point of note: excit would be useful for other parts of AML, in particular topology management.

-> We've settled for an index_byiter for now, but we might need to do both in the end.

Second design choice: do we need to be able to convert two-ways between tile and iterator ?

  • it is difficult to recover a tile coordinates from a layout already
  • it is not clear we need this functionality: we don't have use-cases at this point

-> Leave it for now.

Integration

We need to port the mchpc19 dgemm to this interface.

@iskra-anl
Copy link
Contributor Author

In GitLab by @perarnau on Apr 7, 2020, 13:37

changed the description

@iskra-anl
Copy link
Contributor Author

In GitLab by @perarnau on Aug 14, 2020, 09:27

changed title from Excit Integration to Excit Integration{+: Iterators and Tiling Iterators+}

@iskra-anl
Copy link
Contributor Author

In GitLab by @perarnau on Aug 14, 2020, 09:27

changed the description

@iskra-anl
Copy link
Contributor Author

In GitLab by @perarnau on Aug 14, 2020, 10:17

changed the description

1 similar comment
@iskra-anl
Copy link
Contributor Author

In GitLab by @perarnau on Aug 14, 2020, 10:17

changed the description

@iskra-anl
Copy link
Contributor Author

In GitLab by @perarnau on Aug 14, 2020, 13:54

mentioned in merge request !149

@iskra-anl
Copy link
Contributor Author

In GitLab by @perarnau on Aug 19, 2020, 15:59

changed the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant