Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aml_area_mmap() options #64

Open
iskra-anl opened this issue Apr 20, 2021 · 4 comments
Open

Remove aml_area_mmap() options #64

iskra-anl opened this issue Apr 20, 2021 · 4 comments

Comments

@iskra-anl
Copy link
Contributor

In GitLab by @NicolasDenoyelle on Aug 11, 2020, 13:20

Pros:

  • Interface oblivious of implementation
  • Allocators do not need manage area options with areas but only (more) areas.
  • It becomes possible to duplicate layouts and their pointers without needing area options in function arguments.

Cons:

  • Implies modifications to existing code and tests.
  • Makes area interface closer to an allocator interface.
@iskra-anl
Copy link
Contributor Author

In GitLab by @NicolasDenoyelle on Aug 11, 2020, 13:20

changed the description

@iskra-anl
Copy link
Contributor Author

In GitLab by @NicolasDenoyelle on Aug 11, 2020, 13:21

changed the description

@iskra-anl
Copy link
Contributor Author

In GitLab by @perarnau on Aug 11, 2020, 13:29

One big question for that is if we move these options to area creation, or multiply the number of area implementations.

@iskra-anl
Copy link
Contributor Author

In GitLab by @NicolasDenoyelle on Aug 11, 2020, 14:39

It could be both in my opinion. It all depends whether it makes sense to factorize and/or optimize when we will have a real use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant