Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] usage of UT_icd in nrm_vector_s #30

Open
iddaoudi opened this issue Oct 18, 2022 · 0 comments
Open

[refactor] usage of UT_icd in nrm_vector_s #30

iddaoudi opened this issue Oct 18, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@iddaoudi
Copy link

iddaoudi commented Oct 18, 2022

UT_array already contains UT_icd (see include/internal/utarray.h).
Yet in the definition of the nrm_vector structure (see src/utils/vectors.c), we define UT_array AND UT_icd separately, and then use them as a->array and a->icd.
Code should be refactored to only use UT_array in the definition of nrm_vector and then access the icd via a->array.icd.

@iddaoudi iddaoudi added the enhancement New feature or request label Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant