Skip to content

Commit

Permalink
Associate issues with TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
sug0 committed May 27, 2024
1 parent 339e17d commit a7827af
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions crates/namada/src/vm/wasm/host_env.rs
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ where
}
}

// TODO: Attempt to reduce the boilerplate of this module with macros, traits
// or something of this sort...
// TODO(namada#3313): Attempt to reduce the boilerplate of this module with
// macros, traits or something of this sort...
mod wrap_tx {
//! Wrap tx host functions with any number of arguments in a callback
//! that can be passed to [`wasmer`], to be used by the guest wasm code.
Expand Down Expand Up @@ -258,8 +258,8 @@ mod wrap_tx {
}
}

// TODO: Attempt to reduce the boilerplate of this module with macros, traits
// or something of this sort...
// TODO(namada#3313): Attempt to reduce the boilerplate of this module with
// macros, traits or something of this sort...
mod wrap_vp {
//! Wrap vp host functions with any number of arguments in a callback
//! that can be passed to [`wasmer`], to be used by the guest wasm code.
Expand Down
4 changes: 2 additions & 2 deletions crates/namada/src/vm/wasm/memory.rs
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,8 @@ pub fn write_vp_inputs(

/// Check that the given offset and length fits into the memory bounds. If not,
/// it will try to grow the memory.
// TODO: avoid growing memory if we're only performing reads; return an Err
// instead
// TODO(namada#3314): avoid growing memory if we're only performing reads;
// return an Err instead
fn check_bounds(
store: &mut impl wasmer::AsStoreMut,
memory: &Memory,
Expand Down

0 comments on commit a7827af

Please sign in to comment.