From 18a9eab695bc7fb110ba497e21726f7c1e31b29a Mon Sep 17 00:00:00 2001 From: Marco Granelli Date: Wed, 24 Jul 2024 19:43:38 +0200 Subject: [PATCH 1/2] Fixes misleading fee tracing message --- crates/node/src/protocol.rs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/crates/node/src/protocol.rs b/crates/node/src/protocol.rs index 5014967b69..f4bc782d90 100644 --- a/crates/node/src/protocol.rs +++ b/crates/node/src/protocol.rs @@ -739,8 +739,8 @@ where if !result.is_accepted() { state.write_log_mut().drop_tx(); tracing::error!( - "The fee unshielding tx is invalid, some VPs rejected \ - it: {:#?}", + "The first transaction in the batch failed to pay \ + fees via the MASP, some VPs rejected it: {:#?}", result.vps_result.rejected_vps ); } @@ -777,7 +777,8 @@ where Err(e) => { state.write_log_mut().drop_tx(); tracing::error!( - "The fee unshielding tx is invalid, wasm run failed: {}", + "The first transaction in the batch failed to pay fees \ + via the MASP, wasm run failed: {}", e ); if let Error::GasError(_) = e { From fb60b10d8c4ab2cf4097970131808904cbb9e97c Mon Sep 17 00:00:00 2001 From: Marco Granelli Date: Wed, 24 Jul 2024 19:57:26 +0200 Subject: [PATCH 2/2] Changelog #3547 --- .changelog/unreleased/improvements/3547-fix-fee-log-msg.md | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 .changelog/unreleased/improvements/3547-fix-fee-log-msg.md diff --git a/.changelog/unreleased/improvements/3547-fix-fee-log-msg.md b/.changelog/unreleased/improvements/3547-fix-fee-log-msg.md new file mode 100644 index 0000000000..d365ccfcad --- /dev/null +++ b/.changelog/unreleased/improvements/3547-fix-fee-log-msg.md @@ -0,0 +1,2 @@ +- Improved tracing messages regarding MASP fee payment. + ([\#3547](https://github.com/anoma/namada/pull/3547)) \ No newline at end of file