Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PoS: panic on slashing failure #1270

Closed
Tracked by #2006
tzemanovic opened this issue Mar 31, 2023 · 1 comment · Fixed by #2178
Closed
Tracked by #2006

PoS: panic on slashing failure #1270

tzemanovic opened this issue Mar 31, 2023 · 1 comment · Fixed by #2178
Assignees
@tzemanovic @karbyshev @brentstone
Labels
PoS

Comments

@tzemanovic
Copy link
Member

Depends on #892

In apps/src/lib/node/ledger/shell/mod.rs calls to PoS slash and process_slashes should be switched from error handling with error logging to panics as slashing is a critical system so it's better to shut down in case of an issue. For now, for devnets and testnets stability it's better to just log any errors
@tzemanovic
Copy link
Member Author

we should be in good state to do this after #1612

@cwgoes cwgoes mentioned this issue Oct 20, 2023
Closed
41 tasks
@brentstone brentstone mentioned this issue Nov 14, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tzemanovic tzemanovic

@karbyshev karbyshev

@brentstone brentstone

Labels
PoS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Misc PoS tasks anoma/namada
3 participants
@tzemanovic @karbyshev @brentstone