Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changed keys wrapper for WlStorage #1305

Closed
sug0 opened this issue Apr 18, 2023 · 2 comments
Closed

Add changed keys wrapper for WlStorage #1305

sug0 opened this issue Apr 18, 2023 · 2 comments
Assignees
Labels

Comments

@sug0
Copy link
Contributor

sug0 commented Apr 18, 2023

Introduce a WlStorage wrapper that keeps track of changed storage keys, due to writes or removals. The wrapper should have a finalize() method, that returns a BTreeSet<Key> of changed storage keys. It is not uncommon for me (personally) to forget adding storage key changes to a set of changed keys, so this abstraction would take this burden away by keeping track of the changed keys internally.

@tzemanovic
Copy link
Member

@sug0 I'm not sure if I follow, doesn't the write log already contain this?

@sug0
Copy link
Contributor Author

sug0 commented May 29, 2024

@tzemanovic guess so. the motivation for this was that in the ethereum bridge code we were manually updating a BTreeSet of changed keys, and would forget keys sometimes. the bigger issue here is a need for a refactor on the eth bridge code :D

@sug0 sug0 closed this as completed May 29, 2024
@sug0 sug0 closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants