Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PoS VP panic::catch_unwind #21

Closed
Tracked by #2006
tzemanovic opened this issue Sep 13, 2021 · 2 comments · Fixed by #2145
Closed
Tracked by #2006

Remove PoS VP panic::catch_unwind #21

tzemanovic opened this issue Sep 13, 2021 · 2 comments · Fixed by #2145
Assignees
Milestone

Comments

@tzemanovic
Copy link
Member

tzemanovic commented Sep 13, 2021

Depends on #12, anoma/anoma#435 and #17

Remove the temporary measure in apps/src/lib/node/ledger/protocol/mod.rs and UnwindSafe + RefUnwindSafe impls in shared/src/ledger/pos/vp.rs that runs the PoS VP in a new thread to catch panics.

┆Issue is synchronized with this Asana task by Unito

@cwgoes
Copy link
Contributor

cwgoes commented Jan 12, 2023

@brentstone do you know if this is still applicable?

@tzemanovic
Copy link
Member Author

we still have this in

@cwgoes cwgoes added this to the 0.15 milestone Jan 16, 2023
@github-project-automation github-project-automation bot moved this from Todo to Tested in Devnet in Namada-Old Nov 21, 2023
phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
…and_navigation

# 17 settings/accounts screen and navigation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Tested in Devnet
Development

Successfully merging a pull request may close this issue.

4 participants