Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a panic when calling namadac reveal-pk and the passed public key is already revealed #3070

Closed
wants to merge 4 commits into from

Conversation

TerzoMillenio
Copy link

@TerzoMillenio TerzoMillenio commented Apr 11, 2024

Describe your changes

Closes #3069
When the public key is already revealed, the program panics with message "Public key for address {} already revealed."

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@TerzoMillenio TerzoMillenio marked this pull request as ready for review April 11, 2024 15:52
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.26%. Comparing base (7d70e5a) to head (dcf563c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3070   +/-   ##
=======================================
  Coverage   61.26%   61.26%           
=======================================
  Files         290      290           
  Lines       88556    88556           
=======================================
  Hits        54251    54251           
  Misses      34305    34305           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwgoes
Copy link
Contributor

cwgoes commented May 22, 2024

Hi, thank you for the contribution! 🙌 - would you mind rebasing, and we'll include it in the next release?

@Fraccaman
Copy link
Member

@cwgoes we addresses this in #3245 I think

@cwgoes
Copy link
Contributor

cwgoes commented May 22, 2024

Ah gotcha.

@cwgoes cwgoes closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

namadac reveal-pk has to output a message when the public key for the address is already revealed
3 participants