Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brent/draft+3141+3181+3172 #3187

Closed
wants to merge 215 commits into from
Closed

Brent/draft+3141+3181+3172 #3187

wants to merge 215 commits into from

Conversation

brentstone
Copy link
Collaborator

Describe your changes

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

brentstone and others added 28 commits May 2, 2024 13:55
* yuji/abci-query-height:
  add changelog
  set height for abci_query
Co-authored-by: Gianmarco Fraccaroli <[email protected]>
* tiago/remove-build-warning:
  Fix unused import build warnings
* fraccaman+grarco/remove-benchmark:
  clippy,fmt
  removed outdated benchmarks
* fraccaman/rework-balance:
  Changelog for #3171
  Fix integration tests
  Standardize no balance response
  Improve error msg when no balance owner is found
  Remove `get_token_balance` from apps
  Remove IBC token query command
  Refactor the CLI's balance command
* grarco/remove-delta-map:
  Changelog #3172
  Removes `delta_map` from the `ShieldedContext` and all the code to work with the balance keys
  Removes `query_tx_deltas`
  Changelog #2675
  Removes unused errors and integration test
  Fixes econding. Updates shielded keys and addresses for tests
  Adjusts wasm txs and client args
  Removes masp pin key
  Rmoves old allowlisted gas
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 58.31019% with 1051 lines in your changes are missing coverage. Please review.

Project coverage is 60.16%. Comparing base (9d4de02) to head (8f3c7a5).
Report is 12 commits behind head on main.

Files Patch % Lines
crates/ibc/src/event.rs 46.94% 113 Missing ⚠️
...rates/apps/src/lib/node/ledger/shell/governance.rs 13.67% 101 Missing ⚠️
...tes/apps/src/lib/node/ledger/shell/testing/node.rs 0.00% 89 Missing ⚠️
crates/events/src/extend.rs 74.26% 88 Missing ⚠️
crates/sdk/src/tx.rs 0.00% 79 Missing ⚠️
crates/ibc/src/context/client.rs 17.10% 63 Missing ⚠️
crates/events/src/lib.rs 72.68% 62 Missing ⚠️
crates/sdk/src/masp.rs 0.00% 54 Missing ⚠️
crates/governance/src/event.rs 54.38% 52 Missing ⚠️
crates/sdk/src/rpc.rs 0.00% 32 Missing ⚠️
... and 44 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3187      +/-   ##
==========================================
+ Coverage   59.40%   60.16%   +0.75%     
==========================================
  Files         298      303       +5     
  Lines       92326    92839     +513     
==========================================
+ Hits        54849    55852    +1003     
+ Misses      37477    36987     -490     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants