Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor WASM host references #3273

Merged
merged 5 commits into from
May 21, 2024
Merged

Refactor WASM host references #3273

merged 5 commits into from
May 21, 2024

Conversation

sug0
Copy link
Contributor

@sug0 sug0 commented May 20, 2024

Describe your changes

Refactor WASM host references code.

Indicate on which release or other PRs this topic is based on

#3258

Diff for review: https://github.com/anoma/namada/compare/tiago/dont-export-wasm-mem..tiago/host-ref-refactor

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 91.73554% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 60.23%. Comparing base (4ed6229) to head (f7b9729).

Files Patch % Lines
crates/namada/src/vm/host_env.rs 92.04% 7 Missing ⚠️
crates/namada/src/vm/mod.rs 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3273      +/-   ##
==========================================
- Coverage   60.24%   60.23%   -0.02%     
==========================================
  Files         303      303              
  Lines       93191    93150      -41     
==========================================
- Hits        56145    56106      -39     
+ Misses      37046    37044       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tzemanovic
tzemanovic previously approved these changes May 20, 2024
Copy link
Member

@tzemanovic tzemanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice refactor!

@tzemanovic tzemanovic marked this pull request as ready for review May 20, 2024 15:30
@tzemanovic tzemanovic merged commit 6e99b38 into main May 21, 2024
17 of 19 checks passed
@tzemanovic tzemanovic deleted the tiago/host-ref-refactor branch May 21, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants