Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.36.0 rc #3276

Closed
wants to merge 261 commits into from
Closed

0.36.0 rc #3276

wants to merge 261 commits into from

Conversation

brentstone
Copy link
Collaborator

Describe your changes

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

sug0 and others added 21 commits May 20, 2024 16:55
* 0x4r45h/feat/upgrade-docker-images:
  add changelog
  upgrade docker images base version to bookworm
* origin/bengt/light-sdk-clone:
  Changelog #2817
  added clone to transaction structs
* origin/tomas/disable-wasm-floats:
  changelog: add #3209
  namada/vm: disable floats in wasm
* origin/tiago/warn-on-non-64bit-arch:
  Changelog for #3215
  Emit CLI warning log msg on non 64-bit hardware
* origin/tiago/chain-init-cleanup:
  Changelog for #3196
  Remove unused global args in `init-network`
  scripts/gen_localnet.py: Parse epoch duration
  scripts/gen_localnet.py: Organize CLI args
  scripts/gen_localnet.py: Support multiple validators
  scripts/gen_localnet.py: Remove chain id from cmd str
  scripts/gen_localnet.py: Log which validator is joining network
  scripts/gen_localnet.py: Add colored output
  scripts/gen_localnet.py: Use modified templates
  scripts/gen_localnet.py: Move `init-network` to fn
  scripts/gen_localnet.py: Copy pre-genesis wallet to validator dir
  scripts/gen_localnet.py: Generalize `join-network`
  scripts/gen_localnet.py: Make script executable
  scripts/gen_localnet.py: Refactor to improve code quality
  scripts/gen_localnet.py: Move code to main function
  scripts/gen_localnet.py: Format code
  Remove fetch wasms CLI cmd
  Optionally add persistent peers to CometBFT
  Introduce helper fns to fetch wasm artifacts dir
  Rework `fetch-wasms` command
  Fix `join-network` in light of `init-network` changes
  Fix `init-network` in integration tests
  Return path to release archive from `init-network`
  Skip nonexistent wasm artifacts in `init-network`
  Only emit chain dist archive from `init-network`
  Do not include base dir in chain dist archive
  Stop copying wasm checksums twice to chain dist archive
  Package wasm artifacts with chain dist
* origin/tomas/update-tower-abci:
  changelog: add #3216
  deps: update tower-abci to v0.13
  deps: update tower-abci to v0.12
* origin/tiago/fix-validator-gas-prices:
  Changelog for #3228
  Test `compute_min_gas_price`
  Address block rejections resulting from lower validator gas prices
* origin/bat/fix/value-sum-invariants:
  update lock files
  [chore]: Upgrade masp deps
  rebasing
  [chore]: changelog
  [fix]: Make the internals of ValueSum private so we know that invariants of representation are maintained
* origin/tomas/more-checked-arith:
  changelog: add #3214
  doc/sdk: fix bare urls
  doc/gas: fix broken link
  apps: fix lint warnings
  apps: add lints
  namada: fix lint warnings
  namada: add lints
  vp_env: fix lint warnings
  vp_env: add lints
  tx_env: add lints
  ethereum_bridge: fix lint warnings
  ethereum_bridge: add lints
  ibc: fix lint warnings
  ibc: add lints
  vm_env: fix lint warnings
  vm_env: add lints
  state: fix lint warnings
  state: add lints
  token: fix lint warnings
  token: add lints
  proof_of_stake: fix lint warnings
  proof_of_stake: add lints
  governance: fix lint warnings
  governance: add lints
  account: fix lint warnings
  account: add lints
  shielded_token: fix lint warnings
  shielded_token: add lints
  trans_token: add lints
  parameters: add lints
  controller: fix lint warnings
  controller: add lints
  storage: fix lint warnings
  storage: add lints
  vote_ext: add lints
  tx: fix lints warnings
  tx: add lints
  gas: fix lints warning
  gas: add lints
  merkle_tree: fix lints warning
  merkle_tree: add lints
  crates: update for checked events gas
  events: use checked arith
  events: add lints
  replay_protection: add lints
* origin/tiago/max-proposal-bytes-validation:
  Changelog for #3220
  Avoid using hardcoded values when configuring CometBFT
  Validate borsh deserialization of ProposalBytes
* origin/bat/fix/issue-1796:
  [misc]: Upped the characters to 80 for line wrapping
  [fix]: Perform the cli help wrapping at comp time
  Update crates/apps/src/lib/cli.rs
  [chore]: changelog
  [fix]: Add line wrapping to the cli commands
* origin/grarco/ferveo-cleanup:
  Updates wrapper tx constructor documentation
  Changelog #3241
  Cleans up ferveo-related things
* origin/tomas/lint-dbg-and-prints:
  changelog: add #3257
  fix lint warnings
  add lints for dbg and prints (except for in tests)
* origin/brent/cleanup-dependencies:
  changelog: add #3218
  respond to comments
  upgrade tracing-log
  use updated fork of tiny-hderive
  use regex workspace
  de-duplicate itertools by upgrading itself and tonic-build
  upgrade ed25519-consensus
  replace dep `parse_duration` with `duration-str`
  update shlex
  update rustls
  update mio
  update libgit2-sys
  update h2
  update eyre
  remove unused dependencies
* origin/tiago/dont-export-wasm-mem:
  Changelog for #3258
  Remove unused WASM memory export
* origin/yuji/tendermint-0.36:
  check event attribute parsing result
  fix test
  update masp
  add changelog
  for clippy
  ibc-rs 0.53
  bump to tendermint-rs 0.36
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 53.57275% with 1254 lines in your changes are missing coverage. Please review.

Project coverage is 60.53%. Comparing base (4ed6229) to head (708af2a).

Current head 708af2a differs from pull request most recent head 6e99b38

Please upload reports for the commit 6e99b38 to get more accurate results.

Files Patch % Lines
crates/namada/src/ledger/native_vp/masp.rs 0.00% 408 Missing ⚠️
crates/core/src/uint.rs 1.60% 123 Missing ⚠️
crates/sdk/src/masp.rs 0.00% 96 Missing ⚠️
crates/namada/src/ledger/protocol/mod.rs 60.79% 69 Missing ⚠️
...s/apps/src/lib/node/ledger/shell/finalize_block.rs 87.02% 62 Missing ⚠️
crates/apps/src/lib/bench_utils.rs 0.00% 52 Missing ⚠️
crates/sdk/src/rpc.rs 0.00% 46 Missing ⚠️
crates/events/src/extend.rs 0.00% 33 Missing ⚠️
crates/namada/src/vm/host_env.rs 82.14% 30 Missing ⚠️
crates/apps/src/lib/config/genesis/chain.rs 12.90% 27 Missing ⚠️
... and 45 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3276      +/-   ##
==========================================
+ Coverage   60.24%   60.53%   +0.28%     
==========================================
  Files         303      301       -2     
  Lines       93191    93926     +735     
==========================================
+ Hits        56145    56860     +715     
- Misses      37046    37066      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* origin/grarco/tx-batch:
  Restores `batch_size` arg for `fetch`
  Refactors `dispatch_tx` to return a result
  Refactors masp events to avoid dynamic attributes
  Short-circuit atomic batches at the first failure
  Implements a `get_tx_data` method on `Ctx`
  Refactors validity booleans into a `ValidityFlags` struct
  Refactors buckets in write log with iterator chains
  Misc refactors, fixes typo
  Improves unit tests for batches
  Refactors match on inner tx result
  Preserve txs order when constructing batch in the sdk
  Drops duplicated events for errored batch
  More unit tests for tx batching
  Appends inner tx result even in case of out of gas
  Better handling of batch errors
  Restores shielded sync struct in the sdk
  Reverts wrong shielded sync cli changes
  Removes broken batch section optimization
  Extracts ok tx result evaluation to a separate function
  Changes error code for batches. Fixes missing events
  Refactors `evaluate_tx_result`. Updates stats
  Renames `TxInfo` and fixes write log commit in `finalize_block`
  Refactors stats accounting
  Reverts `TryFrom` impls for ethereum data to `Tx`
  Changelog #1356
  Adds unit tests for tx batches
  Updates tx types comparisons and avoid duplicated signatures for batches
  Updates error message in ibc test
  Fixes bug in wrapper keys
  Fixes fee payemnt logic and unit tests
  Recomputes signatures for localnet genesis
  Clippy fix
  Removes unused `Ciphertext` section
  Updates `add_inner_tx` to avoid duplicated sections
  Adds new `mk_tx_batch` for unit testing
  Fixes tx interface to attach a new inner tx
  Updates comments
  Adds an SDK function to construct tx batches
  Renames `Commitments` and update docs
  Refactors the batch write log
  Refactors tx result handling in `finalize_block`
  Removes custom borsh impls for `BatchedTx` and `BatchedTxRef`
  More refactoring
  Misc refactoring
  Fixes benchmarks
  Fixes integration tests
  Fixes wasm tests
  Refactors test envs
  Fixes serialization of tx result and unit tests
  Rebuilds wasm for tests
  Recomputes genesis signatures. Fixes missing commitments in tests
  Updates `VpEval`
  Fixes wasm for test. Clippy + fmt
  Updates wasm interface and codes
  Renames batched txs structs
  Misc updates to write log. Updates tx result handling in `finalize_block`
  Updates `WriteLog` to support tx batches
  Improves handling of txs' results in `dispatch_tx` and `finalize_block`
  Introduces `OwnedBatchedTx` for benchmarks. Fixes benches and tests
  Generic `TxResult`
  Updates contexts for batched transactions. Misc updates to protocol
  Updates logs and tx result to support batching
  Adds `BatchedTx` struct and updated the native vps and transactions execution
  Updates core tx methods and masp client functions
  Adds multiple tx commitments in `Header`
* origin/grarco/masp-fees:
  Changelog #3217
  Assigns issues to TODOs
  Removes `wrapper_changed_keys` from `TxResult`
  Removes fee unshielding e2e test
  Removes fee unshielding integration tests
  Recomputes tx test fixture
  Recomputes wasm for tests modules
  Updates TODO comments
  Reworks sdk fee validation
  Renames `wrapper_fee_check`
  Removes error/functions related to fee unshielding
  Removes `descriptions_limit` protocol param
  Removes redundandt wrapper types
  Removes fee unshielding cli and tx args
  Removes `unshield_section_hash` from `WrapperTx`. Updates the relative functions. Removes event for masp wrapper tx
* origin/murisi+grarco/multi-tx-masp-vp-rebased2:
  Enable governance to change MASP token map.
  Moved SignedAmount into core and removed use of unchecked arithmetic.
  Use try_fold to build the ChangedBalances object.
  Created a structure for representing conversion leafs.
  Factored the accumulation code out of verify_sapling_balancing_value.
  Updated the WASM binaries.
  Extend SignedAmount to hold MASP value balance.
  Use a MASP crate that guarantees ValueSums.
  Make MASP VP accept IBC transactions.
  Ensure that all implied transfers have been authorized by the relevant party.
  Split validate_transparent_bundle into 3 functions.
  Now check that the diff between pre and post is the value balance.
  Now decode AssetTypes separately.
  Unifies `DeltaBalance` and `SignedAmount`
  Fix transparent bundle validation bug
  Fixes balances check in masp vp to allow non-masp transfers
  Fixes balance owner when token is minted
  Changelog #2690
  Refactors transparent bundle validation into a separate function. Removes unchecked operation.
  `valid_spend_descriptions_anchor` does not expect the presence of the sapling bundle anymore
  Refactors balances split
  Fixes unrecognized assets
  Refactors transparent bundle check to just compare maps
  Reworks masp vp to accept multiple transfers in a single tx
* origin/tiago/host-ref-refactor:
  Changelog for #3273
  Refactor wasm host references
  Delete unused host slice code
@tzemanovic tzemanovic reopened this May 21, 2024
@tzemanovic tzemanovic closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants