Merklized but not diffed #3293
Merklized but not diffed #3293
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3293 +/- ##
==========================================
+ Coverage 53.79% 53.82% +0.02%
==========================================
Files 314 314
Lines 105784 105843 +59
==========================================
+ Hits 56903 56966 +63
+ Misses 48881 48877 -4 ☔ View full report in Codecov by Sentry. |
| ); | ||
| let make_key = |suffix: u64| { |
There was a problem hiding this comment.
What is this doing exactly? Needs some comments.
There was a problem hiding this comment.
Can you explain what this whole suffix % 3u64 logic is doing, though?
There was a problem hiding this comment.
Also what does "probable" mean in this context?
There was a problem hiding this comment.
these data require proofs of the existence or non-existence
| let tree = | ||
| state.get_merkle_tree(height, Some(StoreType::NoDiff))?; | ||
| assert_eq!(tree.root().0, roots.get(&height).unwrap().0); | ||
| match write_type { |
There was a problem hiding this comment.
Needs comments, this logic is not clear.
There was a problem hiding this comment.
Can you explain the semantics of these 0/1/3 write types?
| ); | ||
| let make_key = |suffix: u64| { |
There was a problem hiding this comment.
Can you explain what this whole suffix % 3u64 logic is doing, though?
| let tree = | ||
| state.get_merkle_tree(height, Some(StoreType::NoDiff))?; | ||
| assert_eq!(tree.root().0, roots.get(&height).unwrap().0); | ||
| match write_type { |
There was a problem hiding this comment.
Can you explain the semantics of these 0/1/3 write types?
crates/node/src/storage/mod.rs
Outdated
| let make_key = |suffix: u64| { | ||
| // For three type keys | ||
| match suffix % 3u64 { | ||
| // for non-probable data |
crates/node/src/storage/mod.rs
Outdated
| match suffix % 3u64 { | ||
| // for non-probable data | ||
| 0 => Key::parse(format!("key{suffix}")).unwrap(), | ||
| // for probable data |
| assert!(!tree.has_key(&merkle_key)?); | ||
| } | ||
| } | ||
| 1 | 3 => { |
There was a problem hiding this comment.
but what do these numbers 1 or 3 mean?
There was a problem hiding this comment.
They're indexes generated by proptest
let blocks_write_type = blocks_write_type.into_iter().enumerate().map(
|(index, write_type)| {
* origin/yuji/merklized-not-diffed: fix typo add comments remove is_merklized_storage_key fix for tests add changelog fmt add NoDiff subtree add diff_key_filter
* origin/yuji/merklized-not-diffed: fix typo add comments remove is_merklized_storage_key fix for tests add changelog fmt add NoDiff subtree add diff_key_filter
Describe your changes
diff_key_filterto check if the data should be stored to diffs even ifmerkle_tree_key_filteris trueNoDiffsubtree in Merkle treeIndicate on which release or other PRs this topic is based on
v0.36.1Checklist before merging to
draft