Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review sig check in masp vp #3311

Open
grarco opened this issue May 24, 2024 · 0 comments
Open

Review sig check in masp vp #3311

grarco opened this issue May 24, 2024 · 0 comments

Comments

@grarco
Copy link
Contributor

grarco commented May 24, 2024

This is a possible(?) breaking improvement of the signature check in the MASP VP.

Could the signature check in the masp vp be done only if the balances decrease more than implied by the Transaction?
As in, if we expect a balance to go down by 10 but we see a decrease of 15 we request a signature since this means that something else happened in parallel to the masp tx that we cannot verify in here. Otherwise, if the decrease matches (or is less than) the exepected value of Transaction we don't require/verify the signature. Could this also apply to validate_transparent_input?

This (if correct) could lead to less signatures needed on the transaction and less verifications.

Originally posted by @grarco in #3186 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants