Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft+3305 #3324

Closed
wants to merge 48 commits into from
Closed

Draft+3305 #3324

wants to merge 48 commits into from

Conversation

brentstone
Copy link
Collaborator

Describe your changes

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

grarco and others added 18 commits May 24, 2024 10:11
* origin/grarco/force-fee-payment:
  Fmt
  Changelog #3075
  Fixes typo
  Misc adjustments to v36
  Adds integration test for enforced fees
  Removes useless operations on wrapper transactions
  Removes useless check on tx type for reprot management
  Fixes unit tests
  Pass tx by reference in `apply_wrapper_tx`
  Removes unused wasm caches for wrapper execution
  Refactors the arguments of `dispatch_tx` for every tx type
  Cache wrapper transaction to avoid second deserialization
  Reorganizes arguments for tx execution
  Refactors tx execution of `finalize_block` into separate functions
  Fixes fee payment
* origin/brent/minor-cleanup:
  WIPPP
  remove folder
  remove unused deps
  improve `ValidatorState` documentation
* stanisloe-2999:
  changelog: add #3305
  remove deprecated dependency from app crate
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 67.57991% with 284 lines in your changes are missing coverage. Please review.

Project coverage is 54.03%. Comparing base (6dc1612) to head (d8aad24).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/sdk/src/masp.rs 0.00% 102 Missing ⚠️
crates/node/src/shell/finalize_block.rs 84.03% 53 Missing ⚠️
crates/namada/src/ledger/protocol/mod.rs 78.78% 28 Missing ⚠️
crates/events/src/tracer.rs 88.66% 23 Missing ⚠️
crates/namada/src/ledger/native_vp/masp.rs 0.00% 17 Missing ⚠️
crates/node/src/shell/governance.rs 0.00% 14 Missing ⚠️
crates/node/src/bench_utils.rs 0.00% 12 Missing ⚠️
crates/apps_lib/src/config/mod.rs 0.00% 9 Missing ⚠️
crates/apps_lib/src/config/global.rs 0.00% 7 Missing ⚠️
crates/core/src/masp.rs 0.00% 7 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3324      +/-   ##
==========================================
+ Coverage   53.89%   54.03%   +0.14%     
==========================================
  Files         314      315       +1     
  Lines      105704   106041     +337     
==========================================
+ Hits        56968    57304     +336     
- Misses      48736    48737       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants