Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wee_alloc in favor of rlsf #3331

Merged
merged 3 commits into from
May 31, 2024
Merged

Conversation

Fraccaman
Copy link
Member

@Fraccaman Fraccaman commented May 29, 2024

Describe your changes

Closes #808.
Closes #401.

Indicate on which release or other PRs this topic is based on

0.37.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 53.89%. Comparing base (5a5838a) to head (8d627ec).

Files Patch % Lines
crates/macros/src/lib.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3331   +/-   ##
=======================================
  Coverage   53.89%   53.89%           
=======================================
  Files         314      314           
  Lines      105704   105704           
=======================================
  Hits        56967    56967           
  Misses      48737    48737           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fraccaman Fraccaman requested review from tzemanovic and sug0 and removed request for tzemanovic May 29, 2024 17:02
@Fraccaman Fraccaman marked this pull request as ready for review May 29, 2024 17:02
@Fraccaman Fraccaman changed the title wip: remove wee_alloc in favor of rlsf Remove wee_alloc in favor of rlsf May 29, 2024
tzemanovic
tzemanovic previously approved these changes May 29, 2024
sug0
sug0 previously approved these changes May 29, 2024
Copy link
Contributor

@sug0 sug0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. just a nit (same as tomas')

genesis/localnet/parameters.toml Outdated Show resolved Hide resolved
@tzemanovic tzemanovic dismissed stale reviews from sug0 and themself via 5f8a798 May 30, 2024 08:13
@tzemanovic tzemanovic force-pushed the fraccaman/replace-wee-alloc branch from 21020de to 5f8a798 Compare May 30, 2024 08:13
tzemanovic
tzemanovic previously approved these changes May 30, 2024
brentstone added a commit that referenced this pull request May 30, 2024
* fraccaman/replace-wee-alloc:
  wasm_for_tests: delete old unused `wasm_source/Cargo.toml`
  changelog: add #3331
  switch wee_alloc for rlsf
brentstone added a commit that referenced this pull request May 30, 2024
* origin/fraccaman/replace-wee-alloc:
  wasm_for_tests: delete old unused `wasm_source/Cargo.toml`
  changelog: add #3331
  switch wee_alloc for rlsf
@brentstone brentstone merged commit 657a604 into main May 31, 2024
16 of 19 checks passed
@brentstone brentstone deleted the fraccaman/replace-wee-alloc branch May 31, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch wasm allocator wee_alloc: wasm memory leaks for large allocations
4 participants