Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop initialized memory when parsing of emitted event origin fails #3344

Open
sug0 opened this issue May 31, 2024 · 0 comments
Open

Drop initialized memory when parsing of emitted event origin fails #3344

sug0 opened this issue May 31, 2024 · 0 comments

Comments

@sug0
Copy link
Contributor

sug0 commented May 31, 2024

Introduced by #3268

When parsing an EventTrace<'a>, if a failure occurs, the memory that has been initialized is never dropped, due to the semantics of MaybeUninit values (which cannot be assumed to be initialized, therefore don't invoke Drop).

These event attributes are hidden behind the debug feature flag, so this bug isn't critical, as event origin attributes are only meant to be used for debugging purposes.

@sug0 sug0 added bug Something isn't working prio:low non-breaking-change labels May 31, 2024
@cwgoes cwgoes added this to the Nice to have and non-breaking milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants