You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't think it changes format- they have the same layout and bit validity except for 0.
That being said, I don't know if using NonZero types gives us much benefit except for rejecting 0. Alternatively we could put any invariants in fn validate_parameters in crates/apps_lib/src/config/genesis/templates.rs and each VP that has parameters should also guard its invariants in its VP implementation (see e.g. crates/proof_of_stake/src/parameters.rsfn validate). I think this is more flexible as we can express more rules than just non-zero.
We should consider changing some of the primitive integer parameters to their
NonZero
equivalentOriginally posted by @sug0 in #3318 (comment)
The text was updated successfully, but these errors were encountered: