Remove old disposable keys from the wallet #3350
Conversation
sug0
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3350 +/- ##
==========================================
+ Coverage 54.05% 54.20% +0.14%
==========================================
Files 315 315
Lines 106296 106405 +109
==========================================
+ Hits 57461 57679 +218
+ Misses 48835 48726 -109 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I still believe the strongest solution would be to wait for a confirmation from the client and one block on top (in case of a rollback) just to have absolute certainty that the transaction has been executed and we don't need the address anymore. Anyway, this solution is already a nice improvement, thanks!
|
@brentstone I think we should increase the key lifetime a bit; let them live for, let's say 1 week, before deleting them |
* tiago/diposable-keys-cleanup: Changelog for #3350 Make `test_disposable_keys_are_garbage_collected` more robust Test that non-disposable keys are not garbage collected Automatically clear disposable keys from the wallet Convert a datetime to a unix timestamp Change naming scheme of disposable signing keys
* origin/tiago/diposable-keys-cleanup: Changelog for #3350 Make `test_disposable_keys_are_garbage_collected` more robust Test that non-disposable keys are not garbage collected Automatically clear disposable keys from the wallet Convert a datetime to a unix timestamp Change naming scheme of disposable signing keys
Describe your changes
Closes #3239
Garbage collect disposable signing keys.
Indicate on which release or other PRs this topic is based on
v0.38.1Checklist before merging to
draft