Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checked assign ops #3374

Merged
merged 2 commits into from
Jul 5, 2024
Merged

checked assign ops #3374

merged 2 commits into from
Jul 5, 2024

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Jun 5, 2024

Describe your changes

A small refactor of assign ops to use the newly supported checked assign ops in smooth-operator.

Indicate on which release or other PRs this topic is based on

v0.39.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

tzemanovic added a commit that referenced this pull request Jun 5, 2024
@tzemanovic tzemanovic marked this pull request as ready for review June 5, 2024 14:29
@tzemanovic tzemanovic requested a review from sug0 June 5, 2024 14:29
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 53.57143% with 13 lines in your changes missing coverage. Please review.

Project coverage is 53.92%. Comparing base (879a326) to head (183aa61).

Files Patch % Lines
crates/sdk/src/queries/vp/pos.rs 0.00% 11 Missing ⚠️
crates/governance/src/utils.rs 83.33% 1 Missing ⚠️
crates/sdk/src/rpc.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3374      +/-   ##
==========================================
- Coverage   53.92%   53.92%   -0.01%     
==========================================
  Files         317      317              
  Lines      107575   107567       -8     
==========================================
- Hits        58011    58003       -8     
  Misses      49564    49564              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sug0
sug0 previously approved these changes Jun 5, 2024
@brentstone brentstone dismissed sug0’s stale review June 6, 2024 07:53

The merge-base changed after approval.

@brentstone brentstone mentioned this pull request Jun 6, 2024
brentstone added a commit that referenced this pull request Jun 6, 2024
* tomas/checked-assign-ops:
  changelog: add #3374
  use the new smooth-operator checked assign ops
@brentstone brentstone merged commit ab829a7 into main Jul 5, 2024
16 of 19 checks passed
@brentstone brentstone deleted the tomas/checked-assign-ops branch July 5, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants