Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk: add impl to shielding transfer #3518

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Conversation

Fraccaman
Copy link
Member

@Fraccaman Fraccaman commented Jul 16, 2024

Describe your changes

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@Fraccaman Fraccaman requested a review from grarco July 16, 2024 12:22
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 53.46%. Comparing base (22a4839) to head (5c1dc13).

Files Patch % Lines
crates/sdk/src/args.rs 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3518      +/-   ##
==========================================
- Coverage   53.47%   53.46%   -0.02%     
==========================================
  Files         320      320              
  Lines      110000   110018      +18     
==========================================
- Hits        58826    58821       -5     
- Misses      51174    51197      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

grarco
grarco previously approved these changes Jul 16, 2024
@Fraccaman Fraccaman marked this pull request as ready for review July 17, 2024 08:43
@brentstone brentstone mentioned this pull request Jul 19, 2024
brentstone added a commit that referenced this pull request Jul 19, 2024
* fraccaman/sdk-builder-fix:
  changelog: add #3518
  sdk: add impl to shielded transfer
  sdk: add impl to shielding transfer
@brentstone brentstone merged commit 460b9dc into main Jul 24, 2024
15 of 19 checks passed
@brentstone brentstone deleted the fraccaman/sdk-builder-fix branch July 24, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants