We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tx
Possible improvement of the way we access the section commitments of an inner tx
enum TxCommitmentRef { Id(TxCommitments), Hash(Hash), Index(usize), } impl TxCommitmentRef { fn get_commitments( &self, batch: impl IntoIterator<Item = &TxCommitments>, ) -> Option<&TxCommitments> { match self { Self::Id(commitments) => { // FIXME: check that `commitments` is present in `batch`? commitments } Self::Hash(commitments_hash) => batch.into_iter().find_map(|commitments| { (hash(commitments) == commitments_hash).then_some(commitments) }), Self::Index(index) => batch.into_iter().nth(index), } } }
Originally posted by @sug0 in #3103 (comment)
The text was updated successfully, but these errors were encountered:
Depends on #3103
Sorry, something went wrong.
@grarco Is this still applicable?
Yes it is
tzemanovic
Successfully merging a pull request may close this issue.
Possible improvement of the way we access the section commitments of an inner tx
Originally posted by @sug0 in #3103 (comment)
The text was updated successfully, but these errors were encountered: