Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider alternative approach to loading MASP params #4258

Open
tzemanovic opened this issue Jan 21, 2025 · 0 comments
Open

consider alternative approach to loading MASP params #4258

tzemanovic opened this issue Jan 21, 2025 · 0 comments

Comments

@tzemanovic
Copy link
Member

In #4251 we had to workaround API requiring MASP params even in cases where those might not be needed (in there it's a workaround for IBC transfer that's not shielded). The solution was to try to continue constructing the tx even if loading params fails.

from @murisi's description

An alternative approach to this PR could be to determine the precise conditions under which MASP build parameters would be required, and only do generation in those circumstances. This also would work fine, but would involve making sure that the determined conditions do not fall out of sync with the transaction building code that follows its usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant