Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger test case generator does not check for chainid #4282

Open
feliam opened this issue Jan 29, 2025 · 0 comments
Open

Ledger test case generator does not check for chainid #4282

feliam opened this issue Jan 29, 2025 · 0 comments
Assignees

Comments

@feliam
Copy link
Collaborator

feliam commented Jan 29, 2025

pub async fn to_ledger_vector(

The testcases for ledger apps generated with "to_ledger_vector" may not be checking for chain-id in the output.
Ledger apps tested with these vector may end up not showing the chain_id and users may be trick to sign mainnet tx while interacting with testnets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants