Fix Multitoken VP to avoid overflow #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yito88
changed the title
2 tasks
Closed
Fraccaman
previously approved these changes
Jan 25, 2024
tzemanovic
previously approved these changes
Jan 25, 2024
tzemanovic
added a commit
that referenced
this pull request
Jan 25, 2024
* yuji/fix-multitoken-vp: vp/multitoken: refactor maps and sets usage add changelog fix all tokens check diffs
tzemanovic
added a commit
that referenced
this pull request
Jan 25, 2024
tzemanovic
added a commit
that referenced
this pull request
Jan 25, 2024
* yuji/fix-multitoken-vp: vp/multitoken: refactor maps and sets usage add changelog fix all tokens check diffs
tzemanovic
force-pushed
the
yuji/fix-multitoken-vp
branch
from
52b9943
to
7af0769
Compare
tzemanovic
added a commit
that referenced
this pull request
Jan 25, 2024
* yuji/fix-multitoken-vp: vp/multitoken: refactor maps and sets usage add changelog fix all tokens check diffs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The diff had only
I256type, however, it could be an overflow becausepostandpreisAmount(U256).Indicate on which release or other PRs this topic is based on
v0.30.1
Checklist before merging to
draft