Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test ibc e2e fix for #3389 #3420

Closed
wants to merge 18 commits into from
Closed

test ibc e2e fix for #3389 #3420

wants to merge 18 commits into from

Conversation

sug0
Copy link
Contributor

@sug0 sug0 commented Jun 17, 2024

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 87.23404% with 12 lines in your changes missing coverage. Please review.

Project coverage is 53.93%. Comparing base (879a326) to head (b50c81e).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/core/src/time.rs 88.23% 8 Missing ⚠️
crates/apps_lib/src/cli.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3420   +/-   ##
=======================================
  Coverage   53.92%   53.93%           
=======================================
  Files         317      317           
  Lines      107575   107628   +53     
=======================================
+ Hits        58011    58048   +37     
- Misses      49564    49580   +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sug0 sug0 changed the title test ibc e2e fix for #3416 test ibc e2e fix for #3389 Jun 17, 2024
@sug0 sug0 added the testing label Jun 17, 2024
@sug0
Copy link
Contributor Author

sug0 commented Jun 18, 2024

Closing this pr, as it seems #3389's CI is finally passing.

Here are the two additional patches applied to this PR, which was based on #3389:
0001-Wait-for-block-height-2-in-IBC-tests.patch
0002-Avoid-precision-drop-in-timestamp-conversions.patch

@sug0 sug0 closed this Jun 18, 2024
@sug0 sug0 deleted the tiago/draft-test-ci branch June 18, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant