Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft+3459 #3468

Closed
wants to merge 193 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
193 commits
Select commit Hold shift + click to select a range
e02fe43
Now hash the TransferTarget into Transaction transparent outputs.
murisi May 28, 2024
6cbe813
Modified the MASP VP to check the IBC receivers.
murisi May 31, 2024
20d113b
Created a separate type that is either an Address or IBC receiver.
murisi Jun 1, 2024
031ba8a
empty commit
brentstone Jun 6, 2024
6daeaf7
Increase disposable key lifetime
sug0 Jun 6, 2024
e147d7a
Changelog for #3378
sug0 Jun 6, 2024
ca10451
Add block header Namada rpc handler
sug0 Jun 4, 2024
493e453
Implement date time subtraction
sug0 Jun 4, 2024
3cca791
Read epochs per year param
sug0 Jun 4, 2024
93112ea
Add max block duration estimate rpc method
sug0 Jun 4, 2024
64d974d
Retrieve max block time estimate from new rpc method in masp
sug0 Jun 4, 2024
acd92ee
use the new smooth-operator checked assign ops
tzemanovic Jun 5, 2024
183aa61
changelog: add #3374
tzemanovic Jun 5, 2024
743c154
remove check for maximum number of signatures per tx
brentstone Jun 6, 2024
dc23750
changelog: add #3380
brentstone Jun 6, 2024
8bb9f8c
Remove max expected block time param
sug0 Jun 4, 2024
7481d60
Split out `estimate_max_block_time_from_parameters`
sug0 Jun 4, 2024
6b71302
Insert mock block headers into test storage
sug0 Jun 5, 2024
996c48e
Test max block time estimates
sug0 Jun 5, 2024
beadc81
Avoid estimating block time of zero
sug0 Jun 5, 2024
eebf5d9
Import `namada_storage` with `testing` feat
sug0 Jun 5, 2024
2164904
Add additional test coverage for max expected block times
sug0 Jun 6, 2024
e9f5a46
Vectorizes transparent transfers
grarco Jun 2, 2024
36e215b
Vectorizes masp transfers
grarco Jun 3, 2024
3eff3b4
Fixes benchmarks
grarco Jun 3, 2024
453b211
Fixes signature generation for vectorized transfers
grarco Jun 4, 2024
4a94e0e
Check no vectorized transfers in cli
grarco Jun 6, 2024
9d6c19d
Misc improvements to signing for vectorized transfers
grarco Jun 6, 2024
561e4e8
Avoids reloading shielded context
grarco Jun 6, 2024
dd3f19a
shielded_token: store the total rewards minted by MASP
tzemanovic Jun 5, 2024
6d4ff88
sdk: add a query for MASP total rewards
tzemanovic Jun 5, 2024
054f915
client/rpc: print MASP total rewards in conversions query
tzemanovic Jun 5, 2024
3a77b4a
Fmt
grarco Jun 6, 2024
1e98403
Changelog #3356
grarco Jun 4, 2024
9b8aba6
cli: add shell completions generator
tzemanovic May 31, 2024
d776ff2
changelog: add #3343
tzemanovic May 31, 2024
69980be
Introduces masp fee payment
grarco May 29, 2024
40401f4
Passes the correct tx index to masp fee payment check
grarco May 29, 2024
bece3de
Reworks masp fee payment to correctly handle errors. Misc refactors
grarco May 29, 2024
3d9ccc4
`check_fees` checks masp fee payment
grarco May 30, 2024
25dbf81
`check_fees` drop the storage changes in case of failure
grarco May 30, 2024
d5aafd5
Returns `BatchedTxResult` from masp fee payment
grarco May 30, 2024
606a0f0
Renames fee payment gas limit parameter
grarco May 30, 2024
2f072b0
Skips the execution of the first inner tx when masp fee payment
grarco May 31, 2024
ba943ef
Refactors batch execution in case of masp fee payment
grarco May 31, 2024
75a2fdc
update Cargo.lock
brentstone Jun 6, 2024
07522e2
Adds integration tests for masp fee payment
grarco Jun 2, 2024
5a1b578
Removes write log precommit and leverages the batch log
grarco Jun 4, 2024
0e2b488
Different gas cost for storage deletes
grarco Jun 4, 2024
92aafe7
Refactors the write log api
grarco Jun 4, 2024
6cfe4c6
Merge branch 'tomas/checked-assign-ops' (#3374)
brentstone Jun 6, 2024
575cb0e
Merge branch 'tiago/increase-disposable-key-lifetime' (#3378)
brentstone Jun 6, 2024
dcdc548
Merge branch 'tomas/shell-complete' (#3343)
brentstone Jun 6, 2024
5581878
WIP
batconjurer May 24, 2024
2cae5c4
[feat]: Added ability to create snapshots of rocksDb
batconjurer Jun 6, 2024
b3ba1a7
add gas scale to protocol params
brentstone Jun 6, 2024
b0f851f
changelog: add #3375
tzemanovic Jun 6, 2024
bb835a1
[feat]: Added snapshot frequency to config
batconjurer Jun 6, 2024
8969ea0
changelog
batconjurer Jun 6, 2024
a0d05e6
empty commit
brentstone Jun 6, 2024
8bc54e5
Merge branch 'brent/remove-max-sigs' (#3380)
brentstone Jun 7, 2024
2b49dc0
Now check that the IBC events are valid with respect to storage changes.
murisi Jun 4, 2024
ad4bae8
Enforce fixed RFC3339 format
sug0 Jun 7, 2024
4582437
remove epoch multipler check for governance
Fraccaman Jun 7, 2024
7368256
Merge branch 'grarco/vectorize-transfers' (#3356)
brentstone Jun 7, 2024
aa7778f
remove hard-coded gas scale
brentstone Jun 7, 2024
4f793e7
Light error handling
brentstone Jun 7, 2024
18b76ac
Add datetime encoding tests
sug0 Jun 7, 2024
95c1e96
minors
Fraccaman Jun 7, 2024
c2a200a
minors
Fraccaman Jun 7, 2024
e6e9ba1
Merge branch 'tomas/masp-total-rewards' (#3375)
brentstone Jun 7, 2024
120ad8e
Adds support for masp fee payment in sdk
grarco Jun 6, 2024
584d2eb
Removes unused denominate function
grarco Jun 7, 2024
9f390a7
Updates shielded wasm code to handle fee unshielding
grarco Jun 7, 2024
abbf3b2
Split up the IBC validation logic in MASP.
murisi Jun 7, 2024
037f62f
fix and clean up
brentstone Jun 8, 2024
4980b18
some small changes
brentstone Jun 8, 2024
04ac10e
changelog: add #3390
brentstone Jun 9, 2024
468d423
changelog: add #3391
brentstone Jun 9, 2024
37e5995
fixes from comments
brentstone Jun 9, 2024
2039931
Merge branch 'fraccaman/remove-multipler-check-governance' (#3390)
brentstone Jun 10, 2024
112da61
change comment on Gas Display
brentstone Jun 10, 2024
fb0df69
Fixes masp tx generation and integration tests
grarco Jun 8, 2024
ed45335
Remove redundant TODO
sug0 Jun 11, 2024
b55f5bc
Centralized the construction of TransparentAddresses to ensure that e…
murisi Jun 11, 2024
0963ec3
Test inner tx results from batch tx
sug0 Jun 11, 2024
486e404
Changelog for #3401
sug0 Jun 11, 2024
5547f09
Handle the is_sender_chain_source case in the MASP VP.
murisi Jun 11, 2024
743dfec
Update crates/node/src/storage/rocksdb.rs
batconjurer Jun 12, 2024
06d7900
Update crates/node/src/storage/rocksdb.rs
batconjurer Jun 12, 2024
a6b0a29
review comments
batconjurer Jun 12, 2024
423ee7f
Ensure that native tokens can always be decoded.
murisi Jun 12, 2024
0ae6f2b
Reduced the dependence on IBC events.
murisi Jun 12, 2024
8740d8d
fix unit test
brentstone Jun 12, 2024
438a4ab
Merge branch 'base' into murisi/masp-ibc-replay-protection-using-txda…
murisi Jun 12, 2024
f768ef9
addressing review comment
batconjurer Jun 13, 2024
df8c15a
Added changelog
batconjurer Jun 7, 2024
594d26c
tinies
batconjurer Jun 8, 2024
f79afd1
rebasing
batconjurer Jun 12, 2024
217afe3
Masp fee payment for shielded actions
grarco Jun 12, 2024
d6f1206
decode transfer and NFT transfer messages
yito88 Jun 13, 2024
dbf6779
add changelog
yito88 Jun 13, 2024
2434e73
update Hermes
yito88 Jun 6, 2024
c4d788d
Decrease max block time estimate to 1m
sug0 Jun 13, 2024
db67411
Clue IBC max block time estimate from Namada params
sug0 Jun 13, 2024
13ea7b6
Adds missing gas spending key arg to ibc tx
grarco Jun 13, 2024
bab5cde
Changelog #3393
grarco Jun 13, 2024
17adaeb
Adjust IBC timeout values
sug0 Jun 13, 2024
48f58aa
Changelog for #3366
sug0 Jun 5, 2024
08e5664
Subdivided some functions involved in processing IBC packets.
murisi Jun 14, 2024
9698bb7
Panics in fee payment if balance read fails
grarco Jun 14, 2024
70f40a6
Fixes typo
grarco Jun 14, 2024
4f89335
Reuses token transfer
grarco Jun 14, 2024
8c2520e
Merge branch 'tiago/test-batch-tx-events' (#3401)
brentstone Jun 14, 2024
62ab4db
Merge branch 'tiago/remove-max-block-time-param' (#3366)
brentstone Jun 14, 2024
ed74656
Fixes broken docs
grarco Jun 14, 2024
d3c29e2
Upgrade ledger-namada-rs to 0.0.24.
murisi Jun 14, 2024
d6f9a7d
Added changelog entry.
murisi Jun 14, 2024
6026c42
Fixes masp amounts conversion
grarco Jun 16, 2024
d056b13
move masp validation from SDK into shielded_token crate
tzemanovic Jun 17, 2024
a088bdb
Derive inner tx hash using wrapper hash
sug0 Jun 14, 2024
dc0316c
Fixes typo
grarco Jun 18, 2024
d624cc8
Increase gas limit in `FinalizeBlock` tests
sug0 Jun 7, 2024
d43e301
Misc fixes
sug0 Jun 7, 2024
be6ed63
Fix from tm time impl for `DateTimeUtc`
sug0 Jun 7, 2024
b9cf51c
Improve tx salting
sug0 Jun 7, 2024
03ccc85
Increase robustness of datetime test
sug0 Jun 13, 2024
798dfe6
Switch to fixed offset format in UTC
sug0 Jun 13, 2024
6183a62
Keep nanoseconds during CometBFT time conversions
sug0 Jun 13, 2024
6050624
Fix genesis time in tests
sug0 Jun 13, 2024
8589b40
Increase precision of timestamps to 9 nanos
sug0 Jun 18, 2024
45c15e1
gen_localnet.py: Fix genesis time string
sug0 Jun 7, 2024
543942b
Rebuild wasms for tests
sug0 Jun 7, 2024
d1a9e54
Resign localnet genesis txs
sug0 Jun 7, 2024
bcad8e8
Regen tx fixtures
sug0 Jun 18, 2024
7f90393
Changelog for #3389
sug0 Jun 7, 2024
a2854e7
Now map denominations to tokens using ibc_token instead of reverse_qu…
murisi Jun 19, 2024
6739f0b
Removed is_any_shielded_action_balance_key and related code since tha…
murisi Jun 19, 2024
18fe989
Simplify checking packet acknowledgement by assuming the uniqueness o…
murisi Jun 19, 2024
3ca9912
Re-export `either` from `namada_tx`
sug0 Jun 19, 2024
ec1312b
Changelog for #3416
sug0 Jun 18, 2024
8de2ec0
Added more comments and improved function naming.
murisi Jun 19, 2024
0c999bd
Start using IBC ports to determine message formats.
murisi Jun 19, 2024
d0b4f3d
Now charge gas in IBC denom query.
murisi Jun 19, 2024
749c45a
Fixes ibc e2e test
grarco Jun 20, 2024
0a5d480
Update balances in the MASP using a non-mutating style.
murisi Jun 19, 2024
7ff94bd
Added changelog entry.
murisi Jun 20, 2024
76fab4c
Merge branch 'murisi/masp-ibc-replay-protection-using-txdata-on-0.39.…
murisi Jun 20, 2024
9e4d4c9
Removes useless write-log commit in fee payment
grarco Jun 21, 2024
13b4bcd
Renames misleading gas limit variable
grarco Jun 24, 2024
16a2c58
Updated example of expected string
grarco Jun 24, 2024
09df28b
Early sapling balance check in masp vp
grarco Jun 25, 2024
4f03fc3
shielded_token: feature guard validation to avoid compilation into wasm
tzemanovic Jun 17, 2024
d6212b9
changelog: add #3419
tzemanovic Jun 17, 2024
dd907d5
Changelog #2721
grarco Jun 25, 2024
a3bb632
Extracts the sapling value balance directly in `validate_transparent_…
grarco Jun 25, 2024
89b1f2c
Fallible trait bound for block height param in queries
grarco Jun 25, 2024
ec16fd2
Changelog #2891
grarco Jun 25, 2024
8363c34
added maximum amount of stewards as genesis parameter
Fraccaman Jun 25, 2024
ed9415f
improve logs
Fraccaman Jun 25, 2024
5fd8935
fix genesis files
Fraccaman Jun 25, 2024
88e520c
Merge branch 'tiago/consistent-datetime-serialization' (#3389)
brentstone Jun 25, 2024
0b2fb8f
fixup! Merge branch 'tiago/consistent-datetime-serialization' (#3389)
brentstone Jun 25, 2024
0c29ee3
Merge branch 'tiago/uniquely-identify-inner-txs' (#3416)
brentstone Jun 25, 2024
b3ae0f7
fixup! Merge branch 'tiago/uniquely-identify-inner-txs' (#3416)
brentstone Jun 25, 2024
5283608
Merge branch 'yuji/fix-ibc-message-decoding' (#3410)
brentstone Jun 25, 2024
fd0050f
Merge branch 'bat/feat/db-snapshots' (#3383)
brentstone Jun 25, 2024
34cfca6
Merge branch 'murisi/upgrade-ledger-namada-rs-dep' (#3412)
brentstone Jun 25, 2024
e1b5857
Removes fallback logic when failed fee payment
grarco Jun 25, 2024
7aebfda
bug fix: get correct storage key
brentstone Jun 26, 2024
8ac4fce
cleanup
brentstone Jun 26, 2024
3127b76
Generalized the TransparentTransfer to support a shielded action.
murisi Jun 27, 2024
83af4ba
Renamed TransparentTransfer to Transfer.
murisi Jun 27, 2024
6d1b785
Subsumed shielded transfer into generalized transfer.
murisi Jun 27, 2024
7942919
Subsumed shielding transfer into generalized transfer.
murisi Jun 27, 2024
7a80d59
Subsumed unshielding transfer into generalized transfer.
murisi Jun 27, 2024
29a64eb
Remove now dead code.
murisi Jun 27, 2024
25d9675
evil: update hermes
brentstone Jun 27, 2024
cc9d719
Merge branch 'bat/feat/list-and-offer-snapshots' (#3386)
brentstone Jun 28, 2024
267eda2
changelog: add #3442
brentstone Jun 26, 2024
48dfdb5
Merge branch 'fraccaman/limit-pgf-stewards' (#3442)
brentstone Jun 28, 2024
36ab80e
Merge branch 'grarco/sdk-query-height' (#3441)
brentstone Jun 28, 2024
e9dd1b2
Merge branch 'brent/parameterize-gas-scale' (#3391)
brentstone Jun 28, 2024
fef8a91
Merge branch 'tomas/move-verify-shielded' (#3419)
brentstone Jun 28, 2024
9aa04e9
Merge branch 'grarco/masp-fee-payment' (#3393)
brentstone Jun 28, 2024
7dd97fa
evil: fix masp fee payment
brentstone Jun 28, 2024
2936ba2
Merge branch 'grarco/early-sapling-balance-check' (#3439)
brentstone Jun 28, 2024
4455bba
evil: update hermes
brentstone Jun 28, 2024
ddded01
Added a changelog entry.
murisi Jun 28, 2024
6110726
Renamed some data structures.
murisi Jul 1, 2024
317b3ad
Unconstrain transfers and combine transfer amounts.
murisi Jun 28, 2024
98c88ec
Generalized the Transfer event to support reporting multiple account …
murisi Jul 2, 2024
3f467a8
Merge branch 'murisi/unconstrained-transfers' (#3459)
murisi Jul 2, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changelog/unreleased/bug-fixes/3375-masp-total-rewards.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Update native token total supply with MASP rewards.
([\#3375](https://github.com/anoma/namada/pull/3375))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Increase the lifetime of disposable signing keys from 5 minutes to 1 week.
([\#3378](https://github.com/anoma/namada/pull/3378))
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Our `DateTimeUtc` type allowed a relaxed representation of RFC3339 strings.
We now enforce a string subset of this format, to guarantee deterministic
serialization. ([\#3389](https://github.com/anoma/namada/pull/3389))
2 changes: 2 additions & 0 deletions .changelog/unreleased/bug-fixes/3404-fix-ibc-message.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Fix to decode ibc-rs transfer messages
([\#3404](https://github.com/anoma/namada/issues/3404))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Add replay protection to MASP-IBC transactions.
([\#3409](https://github.com/anoma/namada/pull/3409))
2 changes: 2 additions & 0 deletions .changelog/unreleased/features/3356-vectorize-transfers.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Reworked transparent and masp transfers to allow for multiple sources, targets,
tokens and amounts. ([\#3356](https://github.com/anoma/namada/pull/3356))
2 changes: 2 additions & 0 deletions .changelog/unreleased/features/3393-masp-fee-payment.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Added support for fee payment directly from the MASP pool.
([\#3393](https://github.com/anoma/namada/pull/3393))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Moved up the check on the sapling value balance in the masp vp.
([\#2721](https://github.com/anoma/namada/issues/2721))
2 changes: 2 additions & 0 deletions .changelog/unreleased/improvements/2891-sdk-query-height.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Queries methods now requests `TryInto` trait bound for block heights to reduce
the conversion error. ([\#2891](https://github.com/anoma/namada/issues/2891))
11 changes: 11 additions & 0 deletions .changelog/unreleased/improvements/3343-shell-complete.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
- Added a `namada complete` command to generate shell completions. This command
requires `--shell` with one of:
- bash
- elvish
- fish
- powershell
- zsh
- nushell

To use in e.g. bash, run `namada complete --shell bash > /usr/share/bash-completion/completions/namada.bash`.
([\#3343](https://github.com/anoma/namada/pull/3343))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Remove the `max_expected_time_per_block` genesis parameter.
([\#3366](https://github.com/anoma/namada/pull/3366))
2 changes: 2 additions & 0 deletions .changelog/unreleased/improvements/3374-checked-assign-ops.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Refactored checked assign arithmetic operations to use smooth-operator macro.
([\#3374](https://github.com/anoma/namada/pull/3374))
2 changes: 2 additions & 0 deletions .changelog/unreleased/improvements/3375-masp-total-rewards.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Store total MASP rewards and print them in the conversions query.
([\#3375](https://github.com/anoma/namada/pull/3375))
2 changes: 2 additions & 0 deletions .changelog/unreleased/improvements/3380-remove-max-sigs.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Remove the check on the maximum number of signatures allowed per transaction
([\#3380](https://github.com/anoma/namada/pull/3380))
10 changes: 10 additions & 0 deletions .changelog/unreleased/improvements/3383-add-db-snapshots.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
* Resolves the first two points of Issue [\#3307](https://github.com/anoma/namada/issues/3307):
- Add the ability to create chunkable snapshots to our rocksdb implementation
- Spawn a background task to create snapshots are certain blockheights

Specifically adds a config parameter that indicates after how many blocks a
snapshot should be created. If set, then on the corresponding calls to commit,
a background task is spun up that takes a snapshot of rocksDB and writes it
in a convenient format to a file. This file contains metadata of how to be
broken up into chunks. Once a new snapshot is created, older snapshots are
removed. ([\#3383](https://github.com/anoma/namada/pull/3383))
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
- Addresses the third point and part of the fourth point of Issue
[\#3307](https://github.com/anoma/namada/issues/3307)
* Adds chunking logic to snapshots
* Implements the `ListSnapshots` ABCI call
* Implements the `LoadSnapshotChunk` ABCI call

([\#3386](https://github.com/anoma/namada/pull/3386))
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Remove the requirement that the proposal voting period
is some integer multiple of the minimum voting period.
([\#3390](https://github.com/anoma/namada/pull/3390))
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Include the gas scale as a protocol parameter that is
mutable via governance rather than as a hard-coded constant.
([\#3391](https://github.com/anoma/namada/pull/3391))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Upgrade the library used to communicate with hardware wallet
([\#3412](https://github.com/anoma/namada/pull/3412))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Index batched txs via their wrapper and commitment hashes.
([\#3416](https://github.com/anoma/namada/pull/3416))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Moved shielded tx validation out of the SDK crate into shielded token crate.
([\#3419](https://github.com/anoma/namada/pull/3419))
2 changes: 2 additions & 0 deletions .changelog/unreleased/improvements/3442-limit-pgf-stewards.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Enforce an upper limit on the number of PGF stewards allowed to exist at a
given time. ([\#3442](https://github.com/anoma/namada/pull/3442))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Combined the various Transfer formats into one general one.
([\#3446](https://github.com/anoma/namada/pull/3446))
3 changes: 3 additions & 0 deletions .changelog/unreleased/testing/3401-test-batch-tx-events.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Adds additional test coverage to batch tx events emission, to make
sure we correctly build a batch of inner tx events from a batched tx.
([\#3401](https://github.com/anoma/namada/pull/3401))
2 changes: 1 addition & 1 deletion .github/workflows/scripts/hermes.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.8.2-namada-beta11-rc2
1.8.2-namada-beta12-rc4
Loading
Loading