Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systems crate #3472

Merged
merged 4 commits into from
Jul 30, 2024
Merged

systems crate #3472

merged 4 commits into from
Jul 30, 2024

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Jul 2, 2024

Describe your changes

Adding a new systems crate to contain the abstract interfaces, previously added to core crate in the base PR. Also switched to use the concrete storage error and result type instead of the generic associated type which reduces the amount of typing needed one the caller side.

Updated dep graph

deps

Indicate on which release or other PRs this topic is based on

Depends-On: #3402

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@tzemanovic tzemanovic mentioned this pull request Jul 2, 2024
15 tasks
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 85.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 54.51%. Comparing base (1154023) to head (c64c7aa).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/proof_of_stake/src/lib.rs 91.83% 4 Missing ⚠️
crates/parameters/src/lib.rs 40.00% 3 Missing ⚠️
crates/ibc/src/lib.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3472      +/-   ##
==========================================
- Coverage   54.51%   54.51%   -0.01%     
==========================================
  Files         323      323              
  Lines      113288   113277      -11     
==========================================
- Hits        61762    61751      -11     
  Misses      51526    51526              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic mentioned this pull request Jul 2, 2024
4 tasks
@tzemanovic tzemanovic marked this pull request as ready for review July 3, 2024 15:51
@tzemanovic tzemanovic requested a review from sug0 July 3, 2024 15:51
sug0
sug0 previously approved these changes Jul 8, 2024
@tzemanovic tzemanovic dismissed sug0’s stale review July 8, 2024 12:36

The merge-base changed after approval.

tzemanovic added a commit that referenced this pull request Jul 9, 2024
tzemanovic added a commit that referenced this pull request Jul 9, 2024
tzemanovic added a commit that referenced this pull request Jul 9, 2024
tzemanovic added a commit that referenced this pull request Jul 11, 2024
tzemanovic added a commit that referenced this pull request Jul 29, 2024
tzemanovic added a commit that referenced this pull request Jul 29, 2024
@tzemanovic tzemanovic mentioned this pull request Jul 29, 2024
@Fraccaman
Copy link
Member

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Jul 29, 2024

refresh

✅ Pull request refreshed

@sug0
Copy link
Contributor

sug0 commented Jul 30, 2024

@tzemanovic @Fraccaman the changelog ci job is failing for some reason

@tzemanovic
Copy link
Member Author

@tzemanovic @Fraccaman the changelog ci job is failing for some reason

it should be fixed from #3559 but the base of this PR doesn't have this included

@tzemanovic
Copy link
Member Author

https://github.com/Mergifyio rebase

Copy link
Contributor

mergify bot commented Jul 30, 2024

rebase

☑️ Nothing to do

  • -conflict [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • queue-position=-1 [📌 rebase requirement]
  • any of:
    • #commits-behind>0 [📌 rebase requirement]
    • #commits>1 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]

mergify bot added a commit that referenced this pull request Jul 30, 2024
Copy link
Contributor

mergify bot commented Jul 30, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

⛓️ Depends-On Requirements

Requirement based on the presence of Depends-On in the body of the pull request

mergify bot added a commit that referenced this pull request Jul 30, 2024
@mergify mergify bot merged commit c6f1eca into main Jul 30, 2024
20 of 21 checks passed
@mergify mergify bot deleted the tomas/systems-crate branch July 30, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants