-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve offline tx handling #3715
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3715 +/- ##
==========================================
+ Coverage 72.49% 72.68% +0.19%
==========================================
Files 338 338
Lines 104190 104309 +119
==========================================
+ Hits 75535 75822 +287
+ Misses 28655 28487 -168 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple of suggestions
c2d4a48
to
edfb095
Compare
9cd2bc0
to
affb5b2
Compare
failed |
affb5b2
to
0a33340
Compare
there's another (broken) offline signing cmd, |
0a33340
to
34c6ac4
Compare
Describe your changes
Closes #3417.
Checklist before merging
breaking::
labels