Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typed chain ID #3733

Merged
merged 6 commits into from
Sep 6, 2024
Merged

typed chain ID #3733

merged 6 commits into from
Sep 6, 2024

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Aug 30, 2024

Describe your changes

Switched to use typed ChainId instead of a string in all fn get_chain_id.

Depends-On: #3718

diff: https://github.com/anoma/namada/pull/3733/files/c6209226992e444d46abae9173baeb09b76f3fcc..d904873f63b0def8451c0399441375f3c8db0c0c

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

Copy link
Contributor

mergify bot commented Aug 30, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

⛓️ Depends-On Requirements

Requirement based on the presence of Depends-On in the body of the pull request

tzemanovic added a commit that referenced this pull request Aug 30, 2024
@tzemanovic tzemanovic marked this pull request as ready for review August 30, 2024 12:11
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 82.22222% with 112 lines in your changes missing coverage. Please review.

Project coverage is 72.47%. Comparing base (ef00f27) to head (8271805).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
crates/governance/src/finalize_block.rs 81.86% 78 Missing ⚠️
crates/node/src/shell/finalize_block.rs 72.97% 20 Missing ⚠️
crates/node/src/protocol.rs 0.00% 3 Missing ⚠️
crates/ibc/src/vp/context.rs 0.00% 2 Missing ⚠️
crates/storage/src/lib.rs 0.00% 2 Missing ⚠️
crates/trans_token/src/lib.rs 95.45% 2 Missing ⚠️
crates/vp/src/native_vp.rs 33.33% 2 Missing ⚠️
crates/vp_prelude/src/lib.rs 71.42% 2 Missing ⚠️
crates/ibc/src/actions.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3733      +/-   ##
==========================================
+ Coverage   72.41%   72.47%   +0.05%     
==========================================
  Files         335      334       -1     
  Lines      104005   104129     +124     
==========================================
+ Hits        75320    75468     +148     
+ Misses      28685    28661      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tzemanovic added a commit that referenced this pull request Aug 30, 2024
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 2, 2024
tzemanovic added a commit that referenced this pull request Sep 2, 2024
mergify bot added a commit that referenced this pull request Sep 6, 2024
mergify bot added a commit that referenced this pull request Sep 6, 2024
Copy link
Contributor

mergify bot commented Sep 6, 2024

Hey @tzemanovic, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@tzemanovic
Copy link
Member Author

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Sep 6, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request Sep 6, 2024
@mergify mergify bot merged commit 6d1b9da into main Sep 6, 2024
23 checks passed
@mergify mergify bot deleted the tomas/typed-chain-id branch September 6, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants