-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typed chain ID #3733
typed chain ID #3733
Conversation
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. ⛓️ Depends-On RequirementsRequirement based on the presence of
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3733 +/- ##
==========================================
+ Coverage 72.41% 72.47% +0.05%
==========================================
Files 335 334 -1
Lines 104005 104129 +124
==========================================
+ Hits 75320 75468 +148
+ Misses 28685 28661 -24 ☔ View full report in Codecov by Sentry. |
9aa217e
to
d904873
Compare
d904873
to
28ce7f1
Compare
28ce7f1
to
8271805
Compare
Hey @tzemanovic, your pull request has been dequeued due to the following reason: CHECKS_FAILED. |
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Describe your changes
Switched to use typed ChainId instead of a string in all
fn get_chain_id
.Depends-On: #3718
diff: https://github.com/anoma/namada/pull/3733/files/c6209226992e444d46abae9173baeb09b76f3fcc..d904873f63b0def8451c0399441375f3c8db0c0c
Checklist before merging
breaking::
labels