Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: add query consensus validators #3734

Merged
merged 3 commits into from
Sep 8, 2024
Merged

Conversation

Fraccaman
Copy link
Member

Describe your changes

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 72.68%. Comparing base (ee4649b) to head (c18b6cb).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
crates/sdk/src/rpc.rs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3734      +/-   ##
==========================================
- Coverage   72.69%   72.68%   -0.02%     
==========================================
  Files         338      338              
  Lines      104321   104331      +10     
==========================================
- Hits        75840    75836       -4     
- Misses      28481    28495      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone
Copy link
Collaborator

@Fraccaman do you intend to add more code here or is this all of it?

@Fraccaman
Copy link
Member Author

nope

brentstone added a commit that referenced this pull request Sep 6, 2024
@brentstone brentstone force-pushed the fraccaman/query-active-validators branch from a20ac2e to c4ef6c4 Compare September 6, 2024 15:44
@brentstone brentstone added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 6, 2024
@brentstone brentstone force-pushed the fraccaman/query-active-validators branch from c4ef6c4 to c18b6cb Compare September 6, 2024 16:23
mergify bot added a commit that referenced this pull request Sep 8, 2024
@mergify mergify bot merged commit 0d7140f into main Sep 8, 2024
21 of 24 checks passed
@mergify mergify bot deleted the fraccaman/query-active-validators branch September 8, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants