merge queue: embarking main (98437ef) and #3718 together

[mergify]

🎉 This pull request has been checked successfully and will be merged soon. 🎉

Branch main (98437ef) and #3718 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #3718.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue main-queue for merge:

• #approved-reviews-by>=1 [🛡 GitHub branch protection]
  • mv gov sub-module from shell into gov crate #3718
• #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • mv gov sub-module from shell into gov crate #3718
• any of [🛡 GitHub branch protection]:
  • check-neutral=Mergify Merge Protections
  • check-skipped=Mergify Merge Protections
  • check-success=Mergify Merge Protections
• any of [🛡 GitHub branch protection]:
  • check-success=check-benchmarks
  • check-neutral=check-benchmarks
  • check-skipped=check-benchmarks
• any of [🛡 GitHub branch protection]:
  • check-success=check-packages
  • check-neutral=check-packages
  • check-skipped=check-packages
• any of [🛡 GitHub branch protection]:
  • check-success=build-binaries
  • check-neutral=build-binaries
  • check-skipped=build-binaries
• any of [🛡 GitHub branch protection]:
  • check-success=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
  • check-neutral=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
  • check-skipped=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
• any of [🛡 GitHub branch protection]:
  • check-success=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
  • check-neutral=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
  • check-skipped=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
• any of [🛡 GitHub branch protection]:
  • check-success=lints
  • check-neutral=lints
  • check-skipped=lints
• any of [🛡 GitHub branch protection]:
  • check-success=test-unit
  • check-neutral=test-unit
  • check-skipped=test-unit
• any of [🛡 GitHub branch protection]:
  • check-success=test-e2e (0)
  • check-neutral=test-e2e (0)
  • check-skipped=test-e2e (0)
• any of [🛡 GitHub branch protection]:
  • check-success=test-e2e (1)
  • check-neutral=test-e2e (1)
  • check-skipped=test-e2e (1)
• any of [🛡 GitHub branch protection]:
  • check-success=test-e2e (2)
  • check-neutral=test-e2e (2)
  • check-skipped=test-e2e (2)
• any of [🛡 GitHub branch protection]:
  • check-success=test-e2e (3)
  • check-neutral=test-e2e (3)
  • check-skipped=test-e2e (3)
• any of [🛡 GitHub branch protection]:
  • check-success=test-e2e (4)
  • check-neutral=test-e2e (4)
  • check-skipped=test-e2e (4)
• any of [🛡 GitHub branch protection]:
  • check-success=test-integration
  • check-neutral=test-integration
  • check-skipped=test-integration
• any of [🛡 GitHub branch protection]:
  • check-success=test-wasm
  • check-neutral=test-wasm
  • check-skipped=test-wasm

Required conditions to stay in the queue:

• #approved-reviews-by >= 1
  • mv gov sub-module from shell into gov crate #3718
• #approved-reviews-by>=1 [🛡 GitHub branch protection]
  • mv gov sub-module from shell into gov crate #3718
• #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • mv gov sub-module from shell into gov crate #3718
• base = main
  • mv gov sub-module from shell into gov crate #3718
• any of [🛡 GitHub branch protection]:
  • check-neutral=Mergify Merge Protections
    • mv gov sub-module from shell into gov crate #3718
  • check-skipped=Mergify Merge Protections
    • mv gov sub-module from shell into gov crate #3718
  • check-success=Mergify Merge Protections
    • mv gov sub-module from shell into gov crate #3718
• any of [🛡 GitHub branch protection]:
  • check-success=check-benchmarks
    • mv gov sub-module from shell into gov crate #3718
  • check-neutral=check-benchmarks
    • mv gov sub-module from shell into gov crate #3718
  • check-skipped=check-benchmarks
    • mv gov sub-module from shell into gov crate #3718
• any of [🛡 GitHub branch protection]:
  • check-success=check-packages
    • mv gov sub-module from shell into gov crate #3718
  • check-neutral=check-packages
    • mv gov sub-module from shell into gov crate #3718
  • check-skipped=check-packages
    • mv gov sub-module from shell into gov crate #3718
• any of [🛡 GitHub branch protection]:
  • check-success=build-binaries
    • mv gov sub-module from shell into gov crate #3718
  • check-neutral=build-binaries
    • mv gov sub-module from shell into gov crate #3718
  • check-skipped=build-binaries
    • mv gov sub-module from shell into gov crate #3718
• any of [🛡 GitHub branch protection]:
  • check-success=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • mv gov sub-module from shell into gov crate #3718
  • check-neutral=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • mv gov sub-module from shell into gov crate #3718
  • check-skipped=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • mv gov sub-module from shell into gov crate #3718
• any of [🛡 GitHub branch protection]:
  • check-success=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
    • mv gov sub-module from shell into gov crate #3718
  • check-neutral=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
    • mv gov sub-module from shell into gov crate #3718
  • check-skipped=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
    • mv gov sub-module from shell into gov crate #3718
• any of [🛡 GitHub branch protection]:
  • check-success=lints
    • mv gov sub-module from shell into gov crate #3718
  • check-neutral=lints
    • mv gov sub-module from shell into gov crate #3718
  • check-skipped=lints
    • mv gov sub-module from shell into gov crate #3718
• any of [🛡 GitHub branch protection]:
  • check-success=test-unit
    • mv gov sub-module from shell into gov crate #3718
  • check-neutral=test-unit
    • mv gov sub-module from shell into gov crate #3718
  • check-skipped=test-unit
    • mv gov sub-module from shell into gov crate #3718
• any of [🛡 GitHub branch protection]:
  • check-success=test-e2e (0)
    • mv gov sub-module from shell into gov crate #3718
  • check-neutral=test-e2e (0)
    • mv gov sub-module from shell into gov crate #3718
  • check-skipped=test-e2e (0)
    • mv gov sub-module from shell into gov crate #3718
• any of [🛡 GitHub branch protection]:
  • check-success=test-e2e (1)
    • mv gov sub-module from shell into gov crate #3718
  • check-neutral=test-e2e (1)
    • mv gov sub-module from shell into gov crate #3718
  • check-skipped=test-e2e (1)
    • mv gov sub-module from shell into gov crate #3718
• any of [🛡 GitHub branch protection]:
  • check-success=test-e2e (2)
    • mv gov sub-module from shell into gov crate #3718
  • check-neutral=test-e2e (2)
    • mv gov sub-module from shell into gov crate #3718
  • check-skipped=test-e2e (2)
    • mv gov sub-module from shell into gov crate #3718
• any of [🛡 GitHub branch protection]:
  • check-success=test-e2e (3)
    • mv gov sub-module from shell into gov crate #3718
  • check-neutral=test-e2e (3)
    • mv gov sub-module from shell into gov crate #3718
  • check-skipped=test-e2e (3)
    • mv gov sub-module from shell into gov crate #3718
• any of [🛡 GitHub branch protection]:
  • check-success=test-e2e (4)
    • mv gov sub-module from shell into gov crate #3718
  • check-neutral=test-e2e (4)
    • mv gov sub-module from shell into gov crate #3718
  • check-skipped=test-e2e (4)
    • mv gov sub-module from shell into gov crate #3718
• any of [🛡 GitHub branch protection]:
  • check-success=test-integration
    • mv gov sub-module from shell into gov crate #3718
  • check-neutral=test-integration
    • mv gov sub-module from shell into gov crate #3718
  • check-skipped=test-integration
    • mv gov sub-module from shell into gov crate #3718
• any of [🛡 GitHub branch protection]:
  • check-success=test-wasm
    • mv gov sub-module from shell into gov crate #3718
  • check-neutral=test-wasm
    • mv gov sub-module from shell into gov crate #3718
  • check-skipped=test-wasm
    • mv gov sub-module from shell into gov crate #3718

---
previous_failed_batches: []
pull_requests:
  - number: 3718
...

[codecov]

Codecov Report

Attention: Patch coverage is 82.91874% with 103 lines in your changes missing coverage. Please review.

Project coverage is 72.48%. Comparing base (98437ef) to head (0039bc4).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/governance/src/finalize_block.rs	81.86%	78 Missing ⚠️
crates/node/src/shell/finalize_block.rs	72.97%	20 Missing ⚠️
crates/node/src/protocol.rs	0.00%	3 Missing ⚠️
crates/trans_token/src/lib.rs	95.45%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3763      +/-   ##
==========================================
+ Coverage   72.41%   72.48%   +0.06%     
==========================================
  Files         339      338       -1     
  Lines      104006   104128     +122     
==========================================
+ Hits        75315    75473     +158     
+ Misses      28691    28655      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.