Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check length of validator name in metadata #3779

Merged
merged 2 commits into from
Sep 8, 2024

Conversation

brentstone
Copy link
Collaborator

Describe your changes

When we added name, forgot to include a check on the string length

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

@brentstone brentstone marked this pull request as ready for review September 8, 2024 13:20
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 15 lines in your changes missing coverage. Please review.

Project coverage is 72.68%. Comparing base (59fdda8) to head (46eb69b).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
crates/sdk/src/tx.rs 33.33% 8 Missing ⚠️
crates/apps_lib/src/config/genesis/transactions.rs 22.22% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3779      +/-   ##
==========================================
- Coverage   72.69%   72.68%   -0.02%     
==========================================
  Files         338      338              
  Lines      104324   104345      +21     
==========================================
  Hits        75839    75839              
- Misses      28485    28506      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fraccaman Fraccaman added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 8, 2024
mergify bot added a commit that referenced this pull request Sep 8, 2024
@mergify mergify bot merged commit 1008f60 into main Sep 8, 2024
21 of 23 checks passed
@mergify mergify bot deleted the brent/restrict-metadat-name-len branch September 8, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants