Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dry run rebase #3781

Merged
merged 6 commits into from
Sep 8, 2024

Changelog #3758

1646626
Select commit
Loading
Failed to load commit list.
Merged

Improve dry run rebase #3781

Changelog #3758
1646626
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 8, 2024 in 0s

72.69% (-0.01%) compared to 59fdda8, passed because coverage increased by -0.01% when compared to adjusted base (72.69%)

View this Pull Request on Codecov

72.69% (-0.01%) compared to 59fdda8, passed because coverage increased by -0.01% when compared to adjusted base (72.69%)

Details

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.69%. Comparing base (59fdda8) to head (1646626).

Files with missing lines Patch % Lines
crates/governance/src/vp/mod.rs 0.00% 1 Missing ⚠️
crates/node/src/dry_run_tx.rs 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3781      +/-   ##
==========================================
- Coverage   72.69%   72.69%   -0.01%     
==========================================
  Files         338      338              
  Lines      104324   104299      -25     
==========================================
- Hits        75839    75817      -22     
+ Misses      28485    28482       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.