Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge queue: embarking main (c6ec091) and #3807 together #3813

Closed
wants to merge 11 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 13, 2024

🎉 This pull request has been checked successfully and will be merged soon. 🎉

Branch main (c6ec091) and #3807 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #3807.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue main-queue for merge:

  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e-with-device-automation
    • check-neutral = test-e2e-with-device-automation
    • check-skipped = test-e2e-with-device-automation

Required conditions to stay in the queue:

---
previous_failed_batches: []
pull_requests:
  - number: 3807
...

@mergify mergify bot closed this Sep 13, 2024
@mergify mergify bot deleted the mergify/merge-queue/bffa8abe4d branch September 13, 2024 09:15
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 88.52459% with 98 lines in your changes missing coverage. Please review.

Project coverage is 72.71%. Comparing base (c6ec091) to head (586352e).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
crates/governance/src/vp/pgf.rs 44.23% 29 Missing ⚠️
crates/node/src/protocol.rs 68.65% 21 Missing ⚠️
crates/shielded_token/src/vp.rs 84.93% 11 Missing ⚠️
crates/governance/src/vp/mod.rs 96.19% 10 Missing ⚠️
crates/ethereum_bridge/src/vp/bridge_pool_vp.rs 94.07% 9 Missing ⚠️
crates/node/src/shell/finalize_block.rs 0.00% 8 Missing ⚠️
crates/ethereum_bridge/src/vp/eth_bridge_vp.rs 94.44% 3 Missing ⚠️
crates/trans_token/src/vp.rs 97.08% 3 Missing ⚠️
crates/vp_env/src/lib.rs 66.66% 2 Missing ⚠️
crates/ethereum_bridge/src/vp/nut_vp.rs 94.44% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3813      +/-   ##
==========================================
+ Coverage   72.69%   72.71%   +0.01%     
==========================================
  Files         338      338              
  Lines      104496   104565      +69     
==========================================
+ Hits        75968    76033      +65     
- Misses      28528    28532       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant