crash when "enable volume and fader" "enable equalizer" are activated

[filochard]

Hi
We are getting a strange crash in Mageia 9 built upon wxgtk 3.2
guayadeque.txt

Previously, for Mageia 8 guayadeque worked perfectly, built with guayadeque 4.7 upon wxgtk 3.1.5 and two patches
(I modified the extensions from .patch to .txt : because Github dislike the .patch extension in file names)
guayadeque-0.4.6-wxgtk3.1.txt
guayadeque-0.4.6-wxgtk3.1.6.txt

I don't know where to dig but apparently the code is not compliant with wxgtk 3.2.0

NB I tried to build upon wxgtk 3.2 without the patches but building fails
With the patches building is OK but I get crashes

[filochard]

Hi again
To be sure that it's not because of our rpmbuilding system, I rebuilt guayadeque upon its dependencies from a git clone from march 2023 (applying the patch suggested here : #144 )
I get the same crash :
OK The music library is fulfilled with the directory
OK the playlist is fulfilled with the chosen album
OK the first file is played when I click on the paly button
CRASH when I click on the next button (and when Guayadeque searches the lyrics even when they are already written inside the mp3 file)

NB it seems to be a problem of compliance with some new versions of build requires different inside Mageia8 and Mageia9
.....................Mageia8.. | versus Mageia9
fontconfig 2.13.93 ... | versus 2.14.2
gstreamer.. 1.18.5 .... | versus 1.22.3
taglib........... 1.11.1 .... | versus 1.12
wxgtk ......... 3.1.5 ....... | versus 3.2.1
gcc................10.4.0.......| versus 12.3.0
glibc............. 2.32.........| versus 2.36
sqlite3......... 3.39.2 .....| versus 3.40.1
wxsqlite3.... 4.6.4 .......| versus 4.9.1
gdkpixbuf... 2.42.2.....| versus 2.42.10
dbus.............1.13.18....| versus 1.14.16

When I build I get lots of warning about deprecated functions

[filochard]

PS
I could build a rpm with a git clone from 2020/12/22
with 3 patches :
guayadeque-0.4.6-wxgtk3.1.6.txt
and
guayadeque-0.4.6-wxgtk3.1.txt
and
guayadeque-0.4.6-desktop-shortcuts.txt

this rpm works in Mageia9 as well as for Mageia8

I'm gonna try to build with more recent clones to find when the commits induced a crash

[filochard]

Hi again
We have narrowed the cause of the crash :
It happens only when "enable volume and fader" is activated
Besides this everything works well

NB during the build we get some warning such as :
m_TeeSrcPad = gst_element_get_request_pad( m_Tee, "src_%u" ); is deprecated

I tried to add a patch to have

• m_TeeSrcPad = gst_element_request_pad_simple( m_Tee, "src_%u" ) in FaderPlayerbin.cpp
  without success

NB bis
we need absolutely these 2 patches to build upon wxgtk3.2 :
guayadeque-0.4.6-wxgtk3.1.6.patch
guayadeque-0.4.6-wxgtk3.1.patch
as it was suggested here #144

[filochard]

I narrowed the date when appeared the problem of crash when "enable volume and fader" and "enable equalizer" are activated
I tested the builds of commits from 2021/04/08 to 2021/04/20 ...
with 3 patches :
guayadeque-0.4.6-wxgtk3.1.6.patch
guayadeque-0.4.6-wxgtk3.patch
as it was suggested here #144
and
0001-Fix-compilation-error-with-gcc13-in-taginfo.patch
0001-Fix-compilation-error-with-gcc13-in-taginfo.txt

Until commit from 2021/04/18 (b608f7b) everything was OK even when "enable volume and fader" and "enable equalizer" are activated....

Since commit from 2021/04/20 (a341f64) guayadeque crashes systematically when "enable volume and fader" and "enable equalizer" are activated....

This appears always for the later commits

here the debug file
guayadeque.txt

There's something wrong in the commit of 2021/04/20 (a341f64) that remains since this date
compatibility problem with wxgtk3.2.1 ?
with taglib 1.12 ?
with gcc 12.3.0 ?
with gstreamer 1.22.3 ?

[filochard]

I built the last clone from september 2023 upon wxgtk 3.1.5 without any patch : it doesn't crash with fader and equalizer enabled !

So something goes wrong when building upon wxgtk 3.2

Sasha Lüdecke https://github.com/sluedecke had proposed a patch :
#144
that allowed building with wxgtk 3.2.0 until the commit from 2021/04/18 and get a working guayadeque with no crash

Unfortunately since the commit of 2021/04/20, this patch allows always to build, but guayadeque crashes if Equalizer and Fader and Volume control are activated...

I am not skilled enough to find why, and to create a patch so that Guayadeque won't crash

If anyone could do this that would allow Guayadeque not ending so sadly if it is not compliant with wxgtk 3.2