Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract Caves, Cavers and Clubs into Models #61

Open
anorthall opened this issue Apr 16, 2023 · 0 comments
Open

Abstract Caves, Cavers and Clubs into Models #61

anorthall opened this issue Apr 16, 2023 · 0 comments
Labels
back-end Views, business logic and models features New features that should be implemented

Comments

@anorthall
Copy link
Owner

anorthall commented Apr 16, 2023 •
edited
Loading

At the moment, these fields on a Trip are just text fields. The data should be abstracted into a model which is automatically created at the point of saving the Trip, utilising Django's get_or_create function. A view can then be created to easily bulk update certain cave names or caver names, as well as allowing auto completion of cave names and cavers using select2.

It is important that the Trip add form stays the same as that this process is relatively transparent to users.

This task will involve a significant amount of work to create migrations and update data structures and templates however it will be a significantly improved way to manage the data.

The objects created for "Cavers", "Caves", etc, should be specific to the user.

The implemention of this feature would be important to enable other features, such as #54.
@anorthall anorthall added ideas Ideas for the future logger labels Apr 16, 2023
@anorthall anorthall added this to the v0.3 milestone Apr 24, 2023
@anorthall anorthall added features New features that should be implemented back-end Views, business logic and models and removed logger ideas Ideas for the future labels May 24, 2023
@anorthall anorthall removed this from the v0.3 milestone May 24, 2023
anorthall added a commit that referenced this issue Nov 2, 2023
@anorthall
Abstract cavers into a model (#61) (#206)
586ea09 
* Migrate cavers field to ManyToManyField

* Add Caver model and CRUD views; update tests

* Add URLs to cavers on statistics page

* Add page load tests for Caver model

* Add tests for caver links on profile

* Add tests for caver detail and rename views

* Add tests for caver merge

* Change button styling

* Add tests for linking accounts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
back-end Views, business logic and models features New features that should be implemented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anorthall