Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request - Feature parity with "expand_csv_tags" functionality of ec2 inventory script #91

Open
dmhii opened this issue Jul 2, 2020 · 6 comments · May be fixed by #818
Open

Request - Feature parity with "expand_csv_tags" functionality of ec2 inventory script #91

dmhii opened this issue Jul 2, 2020 · 6 comments · May be fixed by #818
Assignees
@alinabuzachis
Labels
affects_2.10 backlog feature This issue/PR relates to a feature request has_pr inventory inventory plugin jira plugins plugin (any type) waiting_on_contributor Needs help. Feel free to engage to get things unblocked

Comments

@dmhii
Copy link

dmhii commented Jul 2, 2020

SUMMARY

Request - Feature parity with "expand_csv_tags" functionality of ec2 inventory script.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

aws_ec2.py

ADDITIONAL INFORMATION

It would be useful to have the expand_csv_tags functionality from the old inventory script ported to the plugin. That is currently our only blocker from migrating to the ec2 plugin.

I was following a separate issue that awx raised (as they listed this as a potential blocker as well), but it looks like they might have moved on.

ansible/awx#3472
@flowerysong
Copy link
Contributor

I don't have time to finish this right now and get it in shape for merging, but it can be done fairly easily with a custom filter: flowerysong@72f998e

@ansibullbot ansibullbot added affects_2.10 feature This issue/PR relates to a feature request inventory inventory plugin needs_triage labels Aug 19, 2020
@ansibullbot ansibullbot added the plugins plugin (any type) label Aug 27, 2020
@goneri
Copy link
Member

goneri commented Dec 4, 2020

Thank you @flowerysong for your contribution. We agree this is the right way to address the problen. This being said, your filter is generical enough to be included in a more common collection. Like community.general for instance.

waiting_on_contributor

@goneri goneri added waiting_on_contributor Needs help. Feel free to engage to get things unblocked and removed needs_triage labels Dec 16, 2020
@flowerysong
Copy link
Contributor

This is a very specific set of transformations and I don't see any way in which it would be generically useful, but feel free to do whatever. Since this isn't functionality I need it's not likely to be something I work on myself in the foreseeable future.

@goneri
Copy link
Member

goneri commented Dec 18, 2020

Yes indeed, the module is more specific than I initially thought.

@goneri
Copy link
Member

goneri commented Apr 19, 2021

We can address this with either @flowerysong filter plugin, or a new use_contrib_script_compatible_expand_csv_tags for the inventory plugin that would reproduce the same behaviour.

@jillr, @tadeboro, @tremble, do you have an opinion?

@tadeboro
Copy link

We can address this with either @flowerysong filter plugin, or a new use_contrib_script_compatible_expand_csv_tags for the inventory plugin that would reproduce the same behaviour.

I would probably go with the custom filter option because it keeps the inventory plugin free of custom data processing logic.

@goneri goneri added the backlog label May 7, 2021
@alinabuzachis alinabuzachis self-assigned this Aug 10, 2021
@alinabuzachis alinabuzachis linked a pull request May 19, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alinabuzachis alinabuzachis

Labels
affects_2.10 backlog feature This issue/PR relates to a feature request has_pr inventory inventory plugin jira plugins plugin (any type) waiting_on_contributor Needs help. Feel free to engage to get things unblocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Add expand_csv_tags filter for aws_ec2 inventory alinabuzachis/amazon.aws
6 participants
@goneri @tadeboro @flowerysong @alinabuzachis @dmhii @ansibullbot