From f2d0b38b0eeefac8d27055eb20f8d0bada35a295 Mon Sep 17 00:00:00 2001 From: Abhijeet Kasurde Date: Wed, 17 Jul 2024 15:19:57 -0700 Subject: [PATCH] Remove skippy callback Fixes: #350 Signed-off-by: Abhijeet Kasurde --- .github/BOTMETA.yml | 1 - .../fragments/556_remove_skippy_callback.yml | 2 + meta/runtime.yml | 6 --- plugins/callback/skippy.py | 43 ------------------- 4 files changed, 2 insertions(+), 50 deletions(-) create mode 100644 changelogs/fragments/556_remove_skippy_callback.yml delete mode 100644 plugins/callback/skippy.py diff --git a/.github/BOTMETA.yml b/.github/BOTMETA.yml index 60ae92ad5b..ba8b7981a1 100644 --- a/.github/BOTMETA.yml +++ b/.github/BOTMETA.yml @@ -40,7 +40,6 @@ files: labels: debug $plugins/patch.py: labels: patch - $plugins/skippy.py: $plugins/synchronize.py: labels: synchronize $plugins/timer.py: diff --git a/changelogs/fragments/556_remove_skippy_callback.yml b/changelogs/fragments/556_remove_skippy_callback.yml new file mode 100644 index 0000000000..57b19dfe97 --- /dev/null +++ b/changelogs/fragments/556_remove_skippy_callback.yml @@ -0,0 +1,2 @@ +removed_features: + - skippy - Remove skippy pluglin as it is no longer supported(https://github.com/ansible-collections/ansible.posix/issues/350). diff --git a/meta/runtime.yml b/meta/runtime.yml index a96714c782..ce6befd7ba 100644 --- a/meta/runtime.yml +++ b/meta/runtime.yml @@ -1,8 +1,2 @@ --- requires_ansible: ">=2.14.0" -plugin_routing: - callback: - skippy: - deprecation: - removal_date: "2022-06-01" - warning_text: See the plugin documentation for more details diff --git a/plugins/callback/skippy.py b/plugins/callback/skippy.py deleted file mode 100644 index ced28afcb8..0000000000 --- a/plugins/callback/skippy.py +++ /dev/null @@ -1,43 +0,0 @@ -# (c) 2012-2014, Michael DeHaan -# (c) 2017 Ansible Project -# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt) - -# Make coding more python3-ish -from __future__ import (absolute_import, division, print_function) -__metaclass__ = type - -DOCUMENTATION = ''' - name: skippy - type: stdout - requirements: - - set as main display callback - short_description: Ansible screen output that ignores skipped status - deprecated: - why: The 'default' callback plugin now supports this functionality - removed_at_date: '2022-06-01' - alternative: "'default' callback plugin with 'display_skipped_hosts = no' option" - extends_documentation_fragment: - - default_callback - description: - - This callback does the same as the default except it does not output skipped host/task/item status -''' - -from ansible.plugins.callback.default import CallbackModule as CallbackModule_default - - -class CallbackModule(CallbackModule_default): - - ''' - This is the default callback interface, which simply prints messages - to stdout when new callback events are received. - ''' - - CALLBACK_VERSION = 2.0 - CALLBACK_TYPE = 'stdout' - CALLBACK_NAME = 'ansible.posix.skippy' - - def v2_runner_on_skipped(self, result): - pass - - def v2_runner_item_on_skipped(self, result): - pass