From c6597f7292d380cfc7ec056eba9041c5cb4d96c8 Mon Sep 17 00:00:00 2001 From: Sagar Paul Date: Mon, 16 Sep 2024 11:55:44 +0530 Subject: [PATCH] Add support for FiftyGigabitEthernet (#1115) * Add support for FiftyGigabitEthernet * add a changelog --- changelogs/fragments/fix_interface_fifty_interface.yml | 3 +++ plugins/module_utils/network/ios/ios.py | 4 +++- plugins/module_utils/network/ios/utils/utils.py | 4 +++- tests/unit/modules/network/ios/test_ios_interfaces.py | 7 +++++++ 4 files changed, 16 insertions(+), 2 deletions(-) create mode 100644 changelogs/fragments/fix_interface_fifty_interface.yml diff --git a/changelogs/fragments/fix_interface_fifty_interface.yml b/changelogs/fragments/fix_interface_fifty_interface.yml new file mode 100644 index 000000000..3810521f4 --- /dev/null +++ b/changelogs/fragments/fix_interface_fifty_interface.yml @@ -0,0 +1,3 @@ +--- +bugfixes: + - ios_interfaces - Fixes rendering of FiftyGigabitEthernet as it was wrongly rendering FiftyGigabitEthernet as FiveGigabitEthernet. diff --git a/plugins/module_utils/network/ios/ios.py b/plugins/module_utils/network/ios/ios.py index 9ed7a1f27..3c0441e4d 100644 --- a/plugins/module_utils/network/ios/ios.py +++ b/plugins/module_utils/network/ios/ios.py @@ -141,8 +141,10 @@ def _get_number(name): if_type = "FastEthernet" elif name.lower().startswith("fo"): if_type = "FortyGigabitEthernet" - elif name.lower().startswith("fi"): + elif name.lower().startswith("fiv"): if_type = "FiveGigabitEthernet" + elif name.lower().startswith("fif"): + if_type = "FiftyGigabitEthernet" elif name.lower().startswith("et"): if_type = "Ethernet" elif name.lower().startswith("vl"): diff --git a/plugins/module_utils/network/ios/utils/utils.py b/plugins/module_utils/network/ios/utils/utils.py index fbe9f1fab..e79dd14b7 100644 --- a/plugins/module_utils/network/ios/utils/utils.py +++ b/plugins/module_utils/network/ios/utils/utils.py @@ -286,8 +286,10 @@ def _get_number(name): if_type = "FastEthernet" elif name.lower().startswith("fo"): if_type = "FortyGigabitEthernet" - elif name.lower().startswith("fi"): + elif name.lower().startswith("fiv"): if_type = "FiveGigabitEthernet" + elif name.lower().startswith("fif"): + if_type = "FiftyGigabitEthernet" elif name.lower().startswith("long"): if_type = "LongReachEthernet" elif name.lower().startswith("et"): diff --git a/tests/unit/modules/network/ios/test_ios_interfaces.py b/tests/unit/modules/network/ios/test_ios_interfaces.py index 63ee2341b..eeafc72f4 100644 --- a/tests/unit/modules/network/ios/test_ios_interfaces.py +++ b/tests/unit/modules/network/ios/test_ios_interfaces.py @@ -678,6 +678,10 @@ def test_ios_interfaces_rendered(self): "name": "fiveGigabitEthernet", "description": "Ansible UT FiveGigabitEthernet", }, + { + "name": "fiftyGigabitEthernet", + "description": "Ansible UT for fiftyGigabitEthernet", + }, { "name": "ethernet1", "description": "Ansible UT Ethernet", @@ -750,6 +754,9 @@ def test_ios_interfaces_rendered(self): "interface FiveGigabitEthernet", "description Ansible UT FiveGigabitEthernet", "no shutdown", + "interface FiftyGigabitEthernet", + "description Ansible UT for fiftyGigabitEthernet", + "no shutdown", "interface Ethernet1", "description Ansible UT Ethernet", "no shutdown",