From b2d49e07a51ed89c3223dd7d6d6c8a4abef6c995 Mon Sep 17 00:00:00 2001 From: Felix Fontein Date: Mon, 8 Jul 2024 08:05:06 +0200 Subject: [PATCH 1/2] Use our image for container platform test. --- .../docker_container/tasks/tests/options.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/integration/targets/docker_container/tasks/tests/options.yml b/tests/integration/targets/docker_container/tasks/tests/options.yml index 61061b8f1..a7bc0f371 100644 --- a/tests/integration/targets/docker_container/tasks/tests/options.yml +++ b/tests/integration/targets/docker_container/tasks/tests/options.yml @@ -3605,13 +3605,13 @@ avoid such warnings, please quote the value.' in (log_options_2.warnings | defau ## platform ######################################################## #################################################################### -- name: Remove hello-world image +- name: Remove test image docker_image_remove: - name: "{{ docker_test_image_hello_world_platform }}" + name: "{{ docker_test_image_simple_1 }}" - name: platform docker_container: - image: "{{ docker_test_image_hello_world_platform }}" + image: "{{ docker_test_image_simple_1 }}" name: "{{ cname }}" state: present pull: true @@ -3624,7 +3624,7 @@ avoid such warnings, please quote the value.' in (log_options_2.warnings | defau # Docker daemon only returns 'linux' as the platform for the container, # so this has to be handled correctly by our additional code docker_container: - image: "{{ docker_test_image_hello_world_platform }}" + image: "{{ docker_test_image_simple_1 }}" name: "{{ cname }}" state: present platform: linux/amd64 @@ -3634,7 +3634,7 @@ avoid such warnings, please quote the value.' in (log_options_2.warnings | defau - name: platform (idempotency with shorter name) docker_container: - image: "{{ docker_test_image_hello_world_platform }}" + image: "{{ docker_test_image_simple_1 }}" name: "{{ cname }}" state: present platform: linux @@ -3644,7 +3644,7 @@ avoid such warnings, please quote the value.' in (log_options_2.warnings | defau - name: platform (idempotency with shorter name) docker_container: - image: "{{ docker_test_image_hello_world_platform }}" + image: "{{ docker_test_image_simple_1 }}" name: "{{ cname }}" state: present platform: amd64 @@ -3654,7 +3654,7 @@ avoid such warnings, please quote the value.' in (log_options_2.warnings | defau - name: platform (changed) docker_container: - image: "{{ docker_test_image_hello_world_platform }}" + image: "{{ docker_test_image_simple_1 }}" name: "{{ cname }}" state: present pull: true @@ -3669,7 +3669,7 @@ avoid such warnings, please quote the value.' in (log_options_2.warnings | defau - name: platform (idempotency) docker_container: - image: "{{ docker_test_image_hello_world_platform }}" + image: "{{ docker_test_image_simple_1 }}" name: "{{ cname }}" state: present pull: true From 73f88f6869af73b63414caa0e55ca6948ba23f44 Mon Sep 17 00:00:00 2001 From: Felix Fontein Date: Mon, 8 Jul 2024 09:04:58 +0200 Subject: [PATCH 2/2] Remove docker_test_image_hello_world_platform image. --- tests/integration/targets/setup_docker/vars/main.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/integration/targets/setup_docker/vars/main.yml b/tests/integration/targets/setup_docker/vars/main.yml index 61d74293e..c618fb9dc 100644 --- a/tests/integration/targets/setup_docker/vars/main.yml +++ b/tests/integration/targets/setup_docker/vars/main.yml @@ -11,7 +11,6 @@ docker_test_image_digest_base: quay.io/ansible/docker-test-containers docker_test_image_hello_world: quay.io/ansible/docker-test-containers:hello-world docker_test_image_hello_world_image_id: sha256:bf756fb1ae65adf866bd8c456593cd24beb6a0a061dedf42b26a993176745f6b docker_test_image_hello_world_base: quay.io/ansible/docker-test-containers -docker_test_image_hello_world_platform: docker.io/library/hello-world:latest docker_test_image_busybox: quay.io/ansible/docker-test-containers:busybox docker_test_image_alpine: quay.io/ansible/docker-test-containers:alpine3.8 docker_test_image_alpine_different: quay.io/ansible/docker-test-containers:alpine3.7