apache2_module fails to disable cgi module

[dhoffend]

Summary

Trying to disable the cgi module while running in mpm_event module will result in a failure, even when cgi module is already disabled.

Disabling the cgi module with community.general.apache2_module will fail with the error message Your MPM seems to be threaded. No automatic actions on module cgi possible.. Doing the same on the commandline with a2dismod cgi will result with the correct messaage cgi is already disabled.

In additional, the ignore_configcheck parameter gets ignored, cause the cgi detection hits earlier

Code:
github.com/ansible-collections/community.general/blob/626c0e104975f2bfe1c85e8816f4b64594e06bed//plugins/modules/apache2_module.py#L285-L287)

Possible solutions:

• Check with a2query -m if the module in question is already enabled (this is our current workaround)
• Check cgi operation only with state: present not absent since the problem happens only when enabling cgi module in threaded mode not the other way
• Skip the cgi detection when ignore_configcheck is set

Issue Type

Bug Report

Component Name

apache2_module

Ansible Version

$ ansible --version
ansible [core 2.15.12]

Community.general Version

$ ansible-galaxy collection list community.general
Collection        Version
----------------- -------
community.general 7.5.2  

But the bug is also present in the current HEAD of community.general cause all operation on cgi are not allowed when threaded module is detected.

Configuration

No response

OS / Environment

Debian 11 and Debian 12

Steps to Reproduce

- name: install apache2 will default to mpm_event
  ansible.builtin.apt:
    name: apache2
    state: present

- name: Disabled already disabled cgi module
  community.general.apache2:
    name: cgi
    state: absent

Expected Results

Result should be OK not FAILED since the module is already disabled

Actual Results

"Your MPM seems to be threaded. No automatic actions on module cgi possible."

Code of Conduct

• I agree to follow the Ansible Code of Conduct

[ansibullbot]

Files identified in the description:

• plugins/modules/apache2_module.py

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @berendt @n0trax
click here for bot help

[russoz]

Hi @dhoffend thanks for reporting.

Just to be on the safe side, could you please repeat the test in the latest (or a more recent) version of the collection? Version 7.x is no longer supported - latest one is 10.x already. Thanks!

[dhoffend]

@russoz I can try to setup a test environment, but since I compared the HEAD code and the mentioned line with the one at 7.x I don’t expect many differences. In the head code the module execution stops before doing any other evaluation. I’ll let you know

[russoz]

You have clearly dug deeper than me, so I am happy to take your word on it.