From e82c8f75f15ab951e4d5e2c63af9eb1f1a13277c Mon Sep 17 00:00:00 2001 From: Joey Grant Date: Wed, 7 Aug 2024 10:10:15 -0400 Subject: [PATCH] fix(nmcli): remove bond from ip_conn_type By `bond` connections being included in the `ip_conn_type` list, the resulting `nmcli` commands include references to `ipv4` and `ipv6` settings. These options are not available to `bond` connection types as stated by the error output in issue #8558. Closes #8558 --- changelogs/fragments/8558-fix-bond-connection-type-options.yml | 2 ++ plugins/modules/nmcli.py | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/8558-fix-bond-connection-type-options.yml diff --git a/changelogs/fragments/8558-fix-bond-connection-type-options.yml b/changelogs/fragments/8558-fix-bond-connection-type-options.yml new file mode 100644 index 00000000000..8f3159faa3e --- /dev/null +++ b/changelogs/fragments/8558-fix-bond-connection-type-options.yml @@ -0,0 +1,2 @@ +minor_changes: + - "nmcli - corrects underlying command formation by no longer including ``ipv4.*`` and ``ipv6.*`` settings when working with ``bond`` connection types (https://github.com/ansible-collections/community.general/issues/8558)." diff --git a/plugins/modules/nmcli.py b/plugins/modules/nmcli.py index 6f0884da925..81d2a691d4a 100644 --- a/plugins/modules/nmcli.py +++ b/plugins/modules/nmcli.py @@ -1951,7 +1951,6 @@ def connection_options(self, detect_change=False): @property def ip_conn_type(self): return self.type in ( - 'bond', 'bridge', 'dummy', 'ethernet',