Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmware_vm_inventory - fixed hostgroups being created automatically when the with_path option is enabled #2248

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

vmware_vm_inventory - fixed hostgroups being created automatically when the with_path option is enabled #2248

wants to merge 9 commits into from

Conversation

dmnagornyi
Copy link

@dmnagornyi dmnagornyi commented Nov 14, 2024 •
edited
Loading

SUMMARY

Fixes #1688
Plugin should not create hostgroups automatically when with_path is true. There is keyed_groups parameter for that.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

community.vmware.vmware_vm_inventory

ADDITIONAL INFORMATION
I just removed a block of code that performed an undocumented function and generated a lot of unnecessary hostgroups.

@dmnagornyi
Removed automatically created the host groups
29a8e86 
Removed the piece that automatically created the host groups from the VM path.
@dmnagornyi
Create 1688-fix-auto-host-groups.yml
9af2fd0
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/89e1a4eaf0fd4a8f94bda9d1d0a6d374

❌ ansible-tox-linters FAILURE in 4m 31s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable217 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable217 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable217_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable217_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

@dmnagornyi
Update vmware_vm_inventory.py
9b65a26 
Removed unnecessary ansible.module_utils.six module.
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/710035b81df94ec68d1b6905a8a0e11e

✔️ ansible-tox-linters SUCCESS in 5m 08s
✔️ build-ansible-collection SUCCESS in 7m 25s
✔️ ansible-test-cloud-integration-vcenter7_only-stable217 SUCCESS in 21m 24s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable217 SUCCESS in 19m 12s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable217_1_of_2 FAILURE in 1h 01m 50s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable217_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 5m 07s

@dmnagornyi
Updated Inventory with rooted 'with_path' option test.
dbc596a 
It makes sense to look for rooted 'path' value in variable instead of group_names
@dmnagornyi
Merge pull request #1 from dmnagornyi/dmnagornyi-patch-1
bc4d196 
Updated Inventory with rooted 'with_path' option test.
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ecac06fa2bbc4ceaa017753f63a621a6

✔️ ansible-tox-linters SUCCESS in 4m 28s
✔️ build-ansible-collection SUCCESS in 7m 23s
✔️ ansible-test-cloud-integration-vcenter7_only-stable217 SUCCESS in 21m 20s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable217 SUCCESS in 18m 58s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable217_1_of_2 SUCCESS in 45m 55s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable217_2_of_2 SUCCESS in 1h 18m 01s
✔️ ansible-galaxy-importer SUCCESS in 3m 18s

@dmnagornyi
Copy link
Author

@mariolenz please take a look when you have a chance. Minimal changes, shouldn't interfere with anything.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/0a83eb601d134e16ab172fee0be2d21b

✔️ ansible-tox-linters SUCCESS in 4m 53s
✔️ build-ansible-collection SUCCESS in 7m 43s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 FAILURE in 14m 55s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 4m 53s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/076235766f954a05b614f929bd749e3f

✔️ ansible-tox-linters SUCCESS in 4m 32s
✔️ build-ansible-collection SUCCESS in 7m 31s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 FAILURE in 14m 34s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 5m 06s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7fa2f04c67424ec383e4b4e86f1a6739

✔️ ansible-tox-linters SUCCESS in 4m 21s
✔️ build-ansible-collection SUCCESS in 7m 38s
✔️ ansible-test-cloud-integration-vcenter7_only-stable218 SUCCESS in 22m 05s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SUCCESS in 20m 51s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 SUCCESS in 52m 57s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 SUCCESS in 55m 27s
✔️ ansible-galaxy-importer SUCCESS in 6m 15s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/0b661f5d55eb415290fbf05621067b23

✔️ ansible-tox-linters SUCCESS in 5m 40s
✔️ build-ansible-collection SUCCESS in 7m 20s
✔️ ansible-test-cloud-integration-vcenter7_only-stable218 SUCCESS in 21m 09s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SUCCESS in 17m 25s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 SUCCESS in 53m 52s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 SUCCESS in 58m 52s
✔️ ansible-galaxy-importer SUCCESS in 3m 04s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/35d1bad04983446f9d8017bc913f9ab5

✔️ ansible-tox-linters SUCCESS in 4m 52s
✔️ build-ansible-collection SUCCESS in 7m 57s
✔️ ansible-test-cloud-integration-vcenter7_only-stable218 SUCCESS in 16m 41s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SUCCESS in 14m 48s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 SUCCESS in 1h 03m 35s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 SUCCESS in 46m 07s
✔️ ansible-galaxy-importer SUCCESS in 6m 00s

@dmnagornyi
Copy link
Author

recheck

Anything else I need to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

community.vmware.vmware_vm_inventory creates groups for each folder in the hosts path
2 participants
@dmnagornyi @mariolenz