Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fallback and fast_rate attributes to LAG interfaces module #458

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add fallback and fast_rate attributes to LAG interfaces module #458

wants to merge 9 commits into from

Conversation

stalabi1
Copy link
Collaborator

@stalabi1 stalabi1 commented Sep 27, 2024 •
edited
Loading

SUMMARY

I added fallback and fast_rate attributes to the LAG interfaces module.

GitHub Issue #
#454
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

sonic_lag_interfaces

OUTPUT

regression-2024-10-15-13-01-36.html.pdf
facts_gathering.log
diff_output.log
merge_lag.log
delete_lag.log

Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document

@ArunSaravananBalachandran ArunSaravananBalachandran linked an issue Oct 7, 2024 that may be closed by this pull request
[FEATURE]: add fast_rate and fallback LAG options #454
Open
ArunSaravananBalachandran
ArunSaravananBalachandran reviewed Oct 12, 2024
View reviewed changes
plugins/module_utils/network/sonic/config/lag_interfaces/lag_interfaces.py Outdated
Comment on lines 667 to 669
url = f'data/sonic-portchannel:sonic-portchannel/PORTCHANNEL/PORTCHANNEL_LIST={name}'
if attr:
url += f'/{attr}'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please skip usage of 'format string', since it resulted in a pylint failure in python 2.7 during an earlier release in ansible automation hub. (Ref: #434)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed f-strings.

@TafkaMax
Copy link
Contributor

Any news when these will be ready and merged?

@kerry-meyer
Copy link
Collaborator

We will target merging of this PR during the next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArunSaravananBalachandran ArunSaravananBalachandran ArunSaravananBalachandran left review comments

@kerry-meyer kerry-meyer Awaiting requested review from kerry-meyer kerry-meyer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: add fast_rate and fallback LAG options
4 participants
@stalabi1 @TafkaMax @kerry-meyer @ArunSaravananBalachandran