From 403fad26d756ce8fac6d514b789bee76b5512c1c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Marcel=20Guti=C3=A9rrez=20Ben=C3=ADtez?= Date: Wed, 6 Mar 2024 11:58:59 -0600 Subject: [PATCH 1/6] Add to the documentation about known issues --- plugins/modules/zos_blockinfile.py | 3 +++ plugins/modules/zos_lineinfile.py | 3 +++ 2 files changed, 6 insertions(+) diff --git a/plugins/modules/zos_blockinfile.py b/plugins/modules/zos_blockinfile.py index 8fd9701da..cf0cdc11f 100644 --- a/plugins/modules/zos_blockinfile.py +++ b/plugins/modules/zos_blockinfile.py @@ -185,6 +185,9 @@ the block will be overwritten on each iteration. - When more then one block should be handled in a file you must change the I(marker) per task. + - If using ZOAU version 1.3.0 and double quotes (") in the block argument, the module + will throw a false negative response. Follow up on the + L(issue in the collection's repository,https://github.com/ansible-collections/ibm_zos_core/issues/1258). seealso: - module: zos_data_set ''' diff --git a/plugins/modules/zos_lineinfile.py b/plugins/modules/zos_lineinfile.py index a6576af12..aef8cb7e0 100644 --- a/plugins/modules/zos_lineinfile.py +++ b/plugins/modules/zos_lineinfile.py @@ -195,6 +195,9 @@ needs to be encoded, it should be cataloged first. - For supported character sets used to encode data, refer to the L(documentation,https://ibm.github.io/z_ansible_collections_doc/ibm_zos_core/docs/source/resources/character_set.html). + - When working with an MVS file and ZOAU version 1.3.0, combining C(regexp) + with either C(insertafter) or C(insertbefore), will throw an error. + Follow up on the L(issue in the collection's repository,https://github.com/ansible-collections/ibm_zos_core/issues/1244). """ EXAMPLES = r""" From 7ed12fa9af392972d5cd9c545431a5bd88c0912b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Marcel=20Guti=C3=A9rrez=20Ben=C3=ADtez?= Date: Wed, 6 Mar 2024 12:07:38 -0600 Subject: [PATCH 2/6] Add fragment --- .../1284_add-at-the-documenation-about-known-issues.yml | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 changelogs/fragments/1284_add-at-the-documenation-about-known-issues.yml diff --git a/changelogs/fragments/1284_add-at-the-documenation-about-known-issues.yml b/changelogs/fragments/1284_add-at-the-documenation-about-known-issues.yml new file mode 100644 index 000000000..c3fa08592 --- /dev/null +++ b/changelogs/fragments/1284_add-at-the-documenation-about-known-issues.yml @@ -0,0 +1,4 @@ +trivial: + - zos_blockinfile - Add information about known issues in notes. + - zos_lineinfile - Add information about known issues in notes. + (https://github.com/ansible-collections/ibm_zos_core/pull/1284). \ No newline at end of file From bd28e8c1831855b5dc79a92059ee5bc54855494d Mon Sep 17 00:00:00 2001 From: Fernando Flores Date: Tue, 19 Mar 2024 11:26:45 -0600 Subject: [PATCH 3/6] Update 1284_add-at-the-documenation-about-known-issues.yml --- .../1284_add-at-the-documenation-about-known-issues.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/changelogs/fragments/1284_add-at-the-documenation-about-known-issues.yml b/changelogs/fragments/1284_add-at-the-documenation-about-known-issues.yml index c3fa08592..13f364978 100644 --- a/changelogs/fragments/1284_add-at-the-documenation-about-known-issues.yml +++ b/changelogs/fragments/1284_add-at-the-documenation-about-known-issues.yml @@ -1,4 +1,5 @@ trivial: - zos_blockinfile - Add information about known issues in notes. + (https://github.com/ansible-collections/ibm_zos_core/pull/1284). - zos_lineinfile - Add information about known issues in notes. - (https://github.com/ansible-collections/ibm_zos_core/pull/1284). \ No newline at end of file + (https://github.com/ansible-collections/ibm_zos_core/pull/1284). From 52a37d1972cf2963ededd01871640fc91fdc8b3e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Marcel=20Guti=C3=A9rrez=20Ben=C3=ADtez?= Date: Thu, 11 Apr 2024 09:54:52 -0600 Subject: [PATCH 4/6] Update documentation --- plugins/modules/zos_blockinfile.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/modules/zos_blockinfile.py b/plugins/modules/zos_blockinfile.py index cf0cdc11f..029d77e68 100644 --- a/plugins/modules/zos_blockinfile.py +++ b/plugins/modules/zos_blockinfile.py @@ -186,7 +186,7 @@ - When more then one block should be handled in a file you must change the I(marker) per task. - If using ZOAU version 1.3.0 and double quotes (") in the block argument, the module - will throw a false negative response. Follow up on the + will throw a response without the found argument. Follow up on the L(issue in the collection's repository,https://github.com/ansible-collections/ibm_zos_core/issues/1258). seealso: - module: zos_data_set From 5909fd22990aad9c74d82850e95e28af1cfcd004 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Marcel=20Guti=C3=A9rrez=20Ben=C3=ADtez?= <68956970+AndreMarcel99@users.noreply.github.com> Date: Wed, 14 Aug 2024 12:39:57 -0600 Subject: [PATCH 5/6] Update zos_lineinfile.py --- plugins/modules/zos_lineinfile.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/modules/zos_lineinfile.py b/plugins/modules/zos_lineinfile.py index aef8cb7e0..b170f30d2 100644 --- a/plugins/modules/zos_lineinfile.py +++ b/plugins/modules/zos_lineinfile.py @@ -195,8 +195,8 @@ needs to be encoded, it should be cataloged first. - For supported character sets used to encode data, refer to the L(documentation,https://ibm.github.io/z_ansible_collections_doc/ibm_zos_core/docs/source/resources/character_set.html). - - When working with an MVS file and ZOAU version 1.3.0, combining C(regexp) - with either C(insertafter) or C(insertbefore), will throw an error. + - When working with ZOAU version 1.3.0, the module fails when C(src) is a data set and + either C(insertafter) or C(insertbefore) is set in addition to C(regexp). Follow up on the L(issue in the collection's repository,https://github.com/ansible-collections/ibm_zos_core/issues/1244). """ From 5dda3bafdf4dec9e81c4ae55e5fd0d5aedee1895 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Marcel=20Guti=C3=A9rrez=20Ben=C3=ADtez?= <68956970+AndreMarcel99@users.noreply.github.com> Date: Wed, 14 Aug 2024 12:40:48 -0600 Subject: [PATCH 6/6] Update zos_blockinfile.py --- plugins/modules/zos_blockinfile.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/plugins/modules/zos_blockinfile.py b/plugins/modules/zos_blockinfile.py index 029d77e68..94e9f6874 100644 --- a/plugins/modules/zos_blockinfile.py +++ b/plugins/modules/zos_blockinfile.py @@ -185,8 +185,9 @@ the block will be overwritten on each iteration. - When more then one block should be handled in a file you must change the I(marker) per task. - - If using ZOAU version 1.3.0 and double quotes (") in the block argument, the module - will throw a response without the found argument. Follow up on the + - With ZOAU version 1.3.0, if double quotes (") are used in the I(block) parameter, the module + fails with an error message containing: 'return content is NOT in json format'. This is currently a + false negative response, where the I(src) is changed, but an error is reported anyhow. Follow up on the issue tracked L(issue in the collection's repository,https://github.com/ansible-collections/ibm_zos_core/issues/1258). seealso: - module: zos_data_set