Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async utils from antsibull-core #1

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

felixfontein
Copy link
Collaborator

@felixfontein felixfontein commented Aug 29, 2024

Disadvantage of having this here: antsibull-changelog so far doesn't depend on aiofiles.

@gotmax23
Copy link
Collaborator

One idea is to make this a dependency-less package and have one extra per module. Each module/package can have something like

try:
    import module
    import other_module
except ImportError as exc:
    raise ImportError(f"{__package__} requires the hashing/io/whatever extra. Please install antsibull-fileutils[EXTRA_NAME]") from exc

On the other hand, aiofiles has no dependencies itself, and it doesn't compile any C extensions or anything, so perhaps not a big deal to add as a hard dependency.

@felixfontein
Copy link
Collaborator Author

After thinking some more about this, I'm for simply merging this and thus adding aiofiles as a dependency.

@felixfontein felixfontein marked this pull request as ready for review September 8, 2024 19:37
felixfontein added a commit to felixfontein/antsibull-core that referenced this pull request Sep 8, 2024
felixfontein added a commit to felixfontein/antsibull-docs that referenced this pull request Sep 8, 2024
felixfontein added a commit to felixfontein/antsibull-build that referenced this pull request Sep 8, 2024
felixfontein added a commit to felixfontein/antsibull-build that referenced this pull request Sep 8, 2024
felixfontein added a commit to felixfontein/antsibull-docs that referenced this pull request Sep 8, 2024
felixfontein added a commit to felixfontein/antsibull-core that referenced this pull request Sep 8, 2024
felixfontein added a commit to felixfontein/antsibull-build that referenced this pull request Sep 8, 2024
felixfontein added a commit to felixfontein/antsibull-core that referenced this pull request Sep 8, 2024
felixfontein added a commit to felixfontein/antsibull-docs that referenced this pull request Sep 8, 2024
felixfontein added a commit to felixfontein/antsibull-core that referenced this pull request Sep 8, 2024
@felixfontein
Copy link
Collaborator Author

@gotmax23
Copy link
Collaborator

gotmax23 commented Sep 9, 2024

After thinking some more about this, I'm for simply merging this and thus adding aiofiles as a dependency.

Sounds good to me!

pyproject.toml Outdated Show resolved Hide resolved
@felixfontein felixfontein merged commit 1a8a0d2 into ansible-community:main Sep 9, 2024
2 checks passed
@felixfontein felixfontein deleted the asyncio branch September 9, 2024 11:38
@felixfontein
Copy link
Collaborator Author

@gotmax23 thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants