-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add async utils from antsibull-core #1
Conversation
One idea is to make this a dependency-less package and have one extra per module. Each module/package can have something like try:
import module
import other_module
except ImportError as exc:
raise ImportError(f"{__package__} requires the hashing/io/whatever extra. Please install antsibull-fileutils[EXTRA_NAME]") from exc On the other hand, aiofiles has no dependencies itself, and it doesn't compile any C extensions or anything, so perhaps not a big deal to add as a hard dependency. |
After thinking some more about this, I'm for simply merging this and thus adding |
afa6fb8
to
814c1e9
Compare
I've adjusted ansible-community/antsibull-core#166, ansible-community/antsibull-build#619, and ansible-community/antsibull-docs#322 to use the code from this PR. |
2cbe6bc
to
57f8eb6
Compare
Sounds good to me! |
Co-authored-by: Maxwell G <[email protected]>
@gotmax23 thanks for reviewing this! |
Disadvantage of having this here: antsibull-changelog so far doesn't depend on aiofiles.