Rewrite copier code to improve symlink handling and preserving metadata #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inspired by #7 (comment).
Symlink handling:
This is closer to what
ansible-galaxy collection build
does,except that its outside detection is not correct IMO (the one here should be better). More precisely, as an example, a symlink pointing to(See below.)../<collection_directory_name>/galaxy.yml
is treated as an outside link by this code, while it is treated as an inside link by ansible-core's code (it computes the absolute path of the destination and checks whether it is prefixed by the absolute path of the collection directory, which in this case would be true).