-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better document local collections for playbooks #1129
Comments
So looking at this page - https://docs.ansible.com/ansible/latest/collections_guide/collections_installing.html - it doesn't specifically mention local collections. So we could add a new section/header to talk about these local collections adjacent to the playbook dir. What do you think about adding a short new section before this one - https://docs.ansible.com/ansible/latest/collections_guide/collections_installing.html#installing-a-collection-from-source-files? |
Food for though: this page https://docs.ansible.com/ansible/latest/tips_tricks/sample_setup.html (which used to be called "Best Practices/Content Organization": https://docs.ansible.com/ansible/2.9/user_guide/playbooks_best_practices.html#content-organization) should probably also mention that putting local collections adjacent to playbooks is possible. |
Estimated effort: M (MUNI tech writers) |
Hello! I would like to work with this issue. I am from the MUNI tech writing course. (This having 2S and 1 M issue to complete) |
So looking at this more deeply, there are two problems to fix:
This is subject to @oraNod 's thoughts/modifications, but here's how I think we can fix this:
Once that PR is merged: |
@samccann Hi, I'm a bit confused with your comment. Did you mean to reference that PR that adds sanity tests or something else? I also think it's a good plan to remove the reusable snippet and create a "proper" section with a heading and anchor that we can reference elsewhere. I'm not sure that needs to be in two separate PRs but it wouldn't hurt. |
@Devids10 Here are some ideas for things you could include in that new section to expand it a little. Feel free to rewrite in your own voice and make whatever tweaks: Installing collections adjacent to playbooksYou can install collections locally next to playbooks in your project instead of in a global location on your system or AWX. This approach has some benefits, such as:
There might be some other things that I'm not thinking about here. @felixfontein might have some ideas (or be a good person to call me out on any nonsense). HTH! |
@oraNod Thank you so much for the ideas. I'll sure look through it and rewrite it if necessary. |
@Devids10 Yes, I think we can remove those lines here https://github.com/ansible/ansible-documentation/blob/devel/docs/docsite/rst/shared_snippets/installing_collections.txt#L59-L68 and put them in a new section. In fact you could probably move the entire contents of the shared snippets file into the RST file where it is referenced, instead of just those specific lines. |
Ah github got too clever for me. I type # 1 (without the space) to mean my first item in the comment, but github treated it as a link to an issue. I edited my comment to remove that confusion. |
@oraNod I have created a draft MR, since I did some changes and created the new section, although currently I am unsure what is this "shared snippets file" and what "RST file" you're talking about. Perhaps I already done what you asked me to do, but some clarification would be great.
EDIT: This time I was looking at the build from readthedocs, and the new section I added is not visible. Why is that? |
…1129 (#1315) * feat: remove the reused snippet * feat: add new shared_snippet and add description of local installation next to playbooks * feat: add new section for installing collections locally * fix: fix nox check error * fix: remove shared txt files, add them to their included space, add an anchor to the new section * fix: comments from the pull request --------- Co-authored-by: Dávid Németh <[email protected]>
…1129 (#1315) * feat: remove the reused snippet * feat: add new shared_snippet and add description of local installation next to playbooks * feat: add new section for installing collections locally * fix: fix nox check error * fix: remove shared txt files, add them to their included space, add an anchor to the new section * fix: comments from the pull request --------- Co-authored-by: Dávid Németh <[email protected]> (cherry picked from commit ba04139)
…1129 (#1315) * feat: remove the reused snippet * feat: add new shared_snippet and add description of local installation next to playbooks * feat: add new section for installing collections locally * fix: fix nox check error * fix: remove shared txt files, add them to their included space, add an anchor to the new section * fix: comments from the pull request --------- Co-authored-by: Dávid Németh <[email protected]> (cherry picked from commit ba04139)
Right now this is mentioned at the bottom of docs/docsite/rst/shared_snippets/installing_collections.txt. This is impossible to link to, and hard to find in general.
Having this documented in a better place would be great!
Ref: https://forum.ansible.com/t/building-html-documentation-for-standalone-local-module-where-to-find-makefile/3915/4
The text was updated successfully, but these errors were encountered: