From a7a3916330a77656382da58fa1032af7a0002bc9 Mon Sep 17 00:00:00 2001 From: Lila Date: Fri, 13 Sep 2024 14:29:52 -0400 Subject: [PATCH 1/2] =?UTF-8?q?=F0=9F=A7=AA=F0=9F=92=85=20Exterminate=20bl?= =?UTF-8?q?anket=20`noqa`=20comments?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- tests/credential_plugins_test.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/credential_plugins_test.py b/tests/credential_plugins_test.py index 8806726c83..acb48bb121 100644 --- a/tests/credential_plugins_test.py +++ b/tests/credential_plugins_test.py @@ -138,12 +138,18 @@ class TestDelineaImports: fallback import.""" def test_dsv_import(self) -> None: - from awx_plugins.credentials.dsv import SecretsVault # noqa + from awx_plugins.credentials.dsv import SecretsVault # noqa: F401 + # assert this module as opposed to older thycotic.secrets.vault assert SecretsVault.__module__ == 'delinea.secrets.vault' def test_tss_import(self) -> None: - from awx_plugins.credentials.tss import DomainPasswordGrantAuthorizer, PasswordGrantAuthorizer, SecretServer, ServerSecret # noqa + from awx_plugins.credentials.tss import ( # noqa: F401 + DomainPasswordGrantAuthorizer, + PasswordGrantAuthorizer, + SecretServer, + ServerSecret, + ) for cls in ( DomainPasswordGrantAuthorizer, From 113d14cadf619f227a852106a3ef2fdb4e29595f Mon Sep 17 00:00:00 2001 From: Sviatoslav Sydorenko Date: Wed, 18 Sep 2024 00:25:48 +0200 Subject: [PATCH 2/2] =?UTF-8?q?=F0=9F=A7=AA=20Start=20enforcing=20`python-?= =?UTF-8?q?check-blanket-noqa`?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/ci-cd.yml | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml index a1d2f83714..0556cd504c 100644 --- a/.github/workflows/ci-cd.yml +++ b/.github/workflows/ci-cd.yml @@ -605,7 +605,7 @@ jobs: - spellcheck-docs environment-variables: - >- # only affects pre-commit, set for all for simplicity: - SKIP=flake8,mypy,pylint,python-check-blanket-noqa + SKIP=flake8,mypy,pylint tox-run-posargs: - '' xfail: @@ -613,13 +613,6 @@ jobs: check-name: - '' include: - - runner-vm-os: ubuntu-latest - python-version: 3.11 - toxenv: pre-commit - environment-variables: '' - tox-run-posargs: python-check-blanket-noqa --all-files - xfail: true - check-name: python-check-blanket-noqa - runner-vm-os: ubuntu-latest python-version: 3.11 toxenv: pre-commit